Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG-11007: Update "Request another letter" screen #9275

Merged
merged 12 commits into from
Oct 2, 2023
Merged

LG-11007: Update "Request another letter" screen #9275

merged 12 commits into from
Oct 2, 2023

Conversation

matthinz
Copy link
Member

@matthinz matthinz commented Sep 27, 2023 •
edited
Loading

🎫 Ticket

LG-11007

🛠 Summary of changes

Cleanup and simplification of the "Request another letter" screen.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Go through IdV and use Verify by mail. Do not enter your OTP.
  • From the "Welcome back" page, click the "Send me another letter" link
  • Verify the "Request another letter?" screen matches the designs

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before:

before

After:

English

margin-y-5-en

Spanish

margin-y-5-es

French

margin-y-5-fr

@matthinz matthinz requested a review from a team September 27, 2023 20:11
@matthinz matthinz force-pushed the matthinz/11007-request-another-letter branch from e7be868 to e2e32c9 Compare September 27, 2023 20:13
soniaconnolly
soniaconnolly reviewed Sep 27, 2023
View reviewed changes
config/locales/idv/es.yml Outdated Show resolved Hide resolved
config/locales/idv/en.yml Outdated Show resolved Hide resolved
config/locales/idv/fr.yml Outdated Show resolved Hide resolved
config/locales/idv/fr.yml Show resolved Hide resolved
matthinz and others added 12 commits September 29, 2023 16:36
@matthinz matthinz force-pushed the matthinz/11007-request-another-letter branch from 592d367 to e20b450 Compare September 29, 2023 23:37
@matthinz matthinz requested a review from soniaconnolly October 2, 2023 16:22
soniaconnolly
soniaconnolly approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@soniaconnolly soniaconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tried it out, looks and works as expected.

@matthinz matthinz merged commit 3302e56 into main Oct 2, 2023
@matthinz matthinz deleted the matthinz/11007-request-another-letter branch October 2, 2023 17:56
@jmhooper jmhooper mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artfulaction artfulaction artfulaction left review comments

@aduth aduth aduth left review comments

@soniaconnolly soniaconnolly soniaconnolly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthinz @aduth @soniaconnolly @artfulaction