Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated name and references #11098

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Conversation

AShukla-GSA
Copy link
Member

No description provided.

@AShukla-GSA AShukla-GSA requested a review from aduth August 16, 2024 15:50
@AShukla-GSA
Copy link
Member Author

#11087

@AShukla-GSA
Copy link
Member Author

Member
AShukla-GSA commented yesterday
🎫 Ticket LG-12167

Link to the relevant ticket:
LG-12167

🛠 Update UnknownError to be GeneralError and changed references

Changed filename, references in other js file and spec files

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to revert one change, but LGTM otherwise 👍

app/javascript/packages/webauthn/is-expected-error.spec.ts Outdated Show resolved Hide resolved
@AShukla-GSA AShukla-GSA merged commit 8632b33 into main Aug 19, 2024
2 checks passed
@AShukla-GSA AShukla-GSA deleted the lg-12167-clean-up-unknown-error-2 branch August 19, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants