Updated name and references (#11098)

* Updated name and refrences * Reverting changes on non front end compnenet * Renamed file resolving PR comment * changelog: internal, code format, change name of class and refrences * Reverting to Unknown error to resolve PR comment * Adding new line to pass lint
18F · Aug 19, 2024 · 8632b33 · 8632b33
1 parent c3225b4
commit 8632b33
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 20 deletions.
diff --git a/app/javascript/packages/document-capture/components/document-capture-review-issues.tsx b/app/javascript/packages/document-capture/components/document-capture-review-issues.tsx
@@ -4,7 +4,7 @@ import { FormStepsButton } from '@18f/identity-form-steps';
 import { Cancel } from '@18f/identity-verify-flow';
 import { useI18n, HtmlTextWithStrongNoWrap } from '@18f/identity-react-i18n';
 import type { FormStepComponentProps } from '@18f/identity-form-steps';
-import UnknownError from './unknown-error';
+import GeneralError from './general-error';
 import TipList from './tip-list';
 import { SelfieCaptureContext } from '../context';
 import {
@@ -53,7 +53,7 @@ function DocumentCaptureReviewIssues({
       {isSelfieCaptureEnabled && (
         <DocumentCaptureSubheaderOne isSelfieCaptureEnabled={isSelfieCaptureEnabled} />
       )}
-      <UnknownError
+      <GeneralError
         unknownFieldErrors={unknownFieldErrors}
         isFailedDocType={isFailedDocType}
         isFailedSelfie={isFailedSelfie}

diff --git a/app/javascript/packages/document-capture/components/document-capture-warning.tsx b/app/javascript/packages/document-capture/components/document-capture-warning.tsx
@@ -5,7 +5,7 @@ import { FormStepError } from '@18f/identity-form-steps';
 import type { I18n } from '@18f/identity-i18n';
 import Warning from './warning';
 import DocumentCaptureTroubleshootingOptions from './document-capture-troubleshooting-options';
-import UnknownError from './unknown-error';
+import GeneralError from './general-error';
 import { InPersonContext } from '../context';
 import AnalyticsContext from '../context/analytics';
 import SelfieCaptureContext from '../context/selfie-capture';
@@ -124,7 +124,7 @@ function DocumentCaptureWarning({
       >
         <div ref={subheadingRef}>{!!subheading && subheading}</div>
         <div ref={errorMessageDisplayedRef}>
-          <UnknownError
+          <GeneralError
             unknownFieldErrors={unknownFieldErrors}
             isFailedDocType={isFailedDocType}
             isFailedSelfie={isFailedSelfie}

diff --git a/...ment-capture/components/unknown-error.tsx → ...ment-capture/components/general-error.tsx b/...ment-capture/components/unknown-error.tsx → ...ment-capture/components/general-error.tsx
@@ -6,7 +6,7 @@ import { Link } from '@18f/identity-components';
 import formatHTML from '@18f/identity-react-i18n/format-html';
 import MarketingSiteContext from '../context/marketing-site';
 
-interface UnknownErrorProps extends ComponentProps<'p'> {
+interface GeneralErrorProps extends ComponentProps<'p'> {
   unknownFieldErrors: FormStepError<{ front: string; back: string }>[];
   isFailedDocType: boolean;
   isFailedSelfie: boolean;
@@ -40,15 +40,15 @@ function getError({ unknownFieldErrors }: GetErrorArguments) {
   return err;
 }
 
-function UnknownError({
+function GeneralError({
   unknownFieldErrors = [],
   isFailedDocType = false,
   isFailedSelfie = false,
   isFailedSelfieLivenessOrQuality = false,
   altFailedDocTypeMsg = null,
   altIsFailedSelfieDontIncludeAttempts = false,
   hasDismissed,
-}: UnknownErrorProps) {
+}: GeneralErrorProps) {
   const { t } = useI18n();
   const { getHelpCenterURL } = useContext(MarketingSiteContext);
   const helpCenterLink = getHelpCenterURL({
@@ -107,4 +107,4 @@ function UnknownError({
   return <p />;
 }
 
-export default UnknownError;
+export default GeneralError;
diff --git a/scripts/enforce-typescript-files.mjs b/scripts/enforce-typescript-files.mjs
@@ -55,7 +55,7 @@ const LEGACY_FILE_EXCEPTIONS = [
   'spec/javascript/packages/document-capture/components/submission-spec.jsx',
   'spec/javascript/packages/document-capture/components/suspense-error-boundary-spec.jsx',
   'spec/javascript/packages/document-capture/components/tip-list-spec.jsx',
-  'spec/javascript/packages/document-capture/components/unknown-error-spec.jsx',
+  'spec/javascript/packages/document-capture/components/general-error-spec.jsx',
   'spec/javascript/packages/document-capture/components/warning-spec.jsx',
   'spec/javascript/packages/document-capture/context/acuant-spec.jsx',
   'spec/javascript/packages/document-capture/context/device-spec.jsx',

diff --git a/...capture/components/unknown-error-spec.jsx → ...capture/components/general-error-spec.jsx b/...capture/components/unknown-error-spec.jsx → ...capture/components/general-error-spec.jsx
@@ -1,21 +1,21 @@
-import UnknownError from '@18f/identity-document-capture/components/unknown-error';
+import GeneralError from '@18f/identity-document-capture/components/general-error';
 import { toFormEntryError } from '@18f/identity-document-capture/services/upload';
 import { within } from '@testing-library/dom';
 import { render } from '../../../support/document-capture';
 
-describe('UnknownError', () => {
+describe('GeneralError', () => {
   context('there is no doc type failure', () => {
     it('render an empty paragraph when no errors', () => {
       const { container } = render(
-        <UnknownError unknownFieldErrors={[]} isFailedDocType={false} />,
+        <GeneralError unknownFieldErrors={[]} isFailedDocType={false} />,
       );
       expect(container.querySelector('p')).to.be.ok();
     });
 
     context('hasDismissed is true', () => {
       it('renders error message with errors and a help center link', () => {
         const { container } = render(
-          <UnknownError
+          <GeneralError
             unknownFieldErrors={[
               {
                 field: 'general',
@@ -36,7 +36,7 @@ describe('UnknownError', () => {
     context('hasDismissed is false', () => {
       it('renders error message with errors but no link', () => {
         const { container, queryByRole } = render(
-          <UnknownError
+          <GeneralError
             unknownFieldErrors={[
               {
                 field: 'general',
@@ -62,7 +62,7 @@ describe('UnknownError', () => {
   context('there is a doc type failure', () => {
     it('renders error message with errors and is a doc type failure', () => {
       const { container } = render(
-        <UnknownError
+        <GeneralError
           unknownFieldErrors={[
             {
               field: 'general',
@@ -78,7 +78,7 @@ describe('UnknownError', () => {
 
     it('renders alternative error message with errors and is a doc type failure', () => {
       const { container } = render(
-        <UnknownError
+        <GeneralError
           unknownFieldErrors={[
             {
               field: 'general',
@@ -97,7 +97,7 @@ describe('UnknownError', () => {
   context('there is a selfie quality/liveness failure', () => {
     it('renders error message with errors', () => {
       const { container } = render(
-        <UnknownError
+        <GeneralError
           unknownFieldErrors={[
             {
               field: 'general',
@@ -112,7 +112,7 @@ describe('UnknownError', () => {
 
     it('renders alternative error message without retry information', () => {
       const { container } = render(
-        <UnknownError
+        <GeneralError
           unknownFieldErrors={[
             {
               field: 'general',
@@ -130,7 +130,7 @@ describe('UnknownError', () => {
   context('there is a selfie facematch failure', () => {
     it('renders error message with errors', () => {
       const { container } = render(
-        <UnknownError
+        <GeneralError
           unknownFieldErrors={[
             {
               field: 'general',
@@ -145,7 +145,7 @@ describe('UnknownError', () => {
 
     it('renders alternative error message without retry information', () => {
       const { container } = render(
-        <UnknownError
+        <GeneralError
           unknownFieldErrors={[
             {
               field: 'general',