Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Album year + sorting #674

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Feat: Album year + sorting #674

merged 2 commits into from
Nov 21, 2024

Conversation

sevonj
Copy link
Contributor

@sevonj sevonj commented Nov 19, 2024

Closes #549

Changes:

  • Add year tag to album
  • Sort by year in album grid

Comments:

Null is treated as the lowest value in sorting.

@sevonj
Copy link
Contributor Author

sevonj commented Nov 21, 2024

Should be OK now:

  • I renamed year to startYear, and added endYear.
  • They track minimum and maximum values from the songs.

I spent too much time tearing my hair out trying to figure why this doesn't work, but apparently the app just couldn't parse the year from mp3 files I created for testing. Probably the same issue as #182.

There are further improvements to make, such as displaying the year, and tracking original year, but I'd rather break those into separate issues.

@zyrouge
Copy link
Owner

zyrouge commented Nov 21, 2024

Should be OK now:

  • I renamed year to startYear, and added endYear.
  • They track minimum and maximum values from the songs.

I spent too much time tearing my hair out trying to figure why this doesn't work, but apparently the app just couldn't parse the year from mp3 files I created for testing. Probably the same issue as #182.

There are further improvements to make, such as displaying the year, and tracking original year, but I'd rather break those into separate issues.

The metadata specification is all over the place and ID3v4 should be supported. Open a issue with the file it did not work with and I'll look into it.

@zyrouge zyrouge merged commit 7baaaad into zyrouge:main Nov 21, 2024
@sevonj sevonj mentioned this pull request Nov 21, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add album sorting by year
2 participants