Feature: Album duration #666
Conversation
|
I think both variants look neat, though I'd expect the menu to have that design/position everywhere. I wouldn't put the album duration next to the track count, however. Makes it look messy. |
app/src/main/java/io/github/zyrouge/symphony/ui/components/GenericGrooveBanner.kt
Show resolved
Hide resolved
| .copy(fontWeight = FontWeight.Bold) | ||
| ) | ||
| } | ||
| Spacer(Modifier.weight(1f)) |
There was a problem hiding this comment.
This will not provide padding when the artists name is long. Add .padding(left = 4.dp) (change the padding according to the necessity).
|
I tested the ui with all kinds of strings, and got more consistent results with a two-column layout instead of fiddling with individual row items.
|
|
I think the design would be much better if we moved the duration to the left. The text near the more options icons looks uncomfortable since they are not aligned. |
| Text(album.name) | ||
| Row(modifier = Modifier.fillMaxWidth()) { | ||
| Row { | ||
| Column( |
There was a problem hiding this comment.
Revert this and add duration as a row.
Like a row? |
|
Maybe the duration could be slightly less bright colored to make it less awkward. |
Yup, that looks for now. We could make changes to the UI in the future. |
I was thinking the same but we might add more metadata such as album start/end year which would make it look less awkward. |
|
With the current design, I'd add the metadata to the same row as in
|
Yeah, that is how I meant. Don't add them in this PR yet. |
|
This should be OK to merge now. |
|
LGTM! |
Closes #588
Changes
screenshot
Comments
Possible further improvements:
I think the UI would look nicer if the menu moved to the top right corner.
mockup
Custom formatting; don't show seconds if duration >= 1 min
Alternatives:
Display the duration in the top bar along with song count.