Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impossible to change position of closeButton #226

Closed
yulian948 opened this issue Feb 3, 2018 · 3 comments
Closed

impossible to change position of closeButton #226

yulian948 opened this issue Feb 3, 2018 · 3 comments

Comments

@yulian948
Copy link

Starting from version 1.5 it's impossible to change position of close button. The reason is that now, close button frame is set in viewDidLayoutSubviews.

@zvonicek
Copy link
Owner

zvonicek commented Feb 3, 2018

Oh, that's unfortunate. Can you think of a better solution that would keep it working but also work well with rotations on iPhone X (safeAreaInsets)?

@yulian948
Copy link
Author

yulian948 commented Feb 3, 2018

Wow, thanks for such a quick reply @zvonicek,

I don't know if it will be a good approach, but we can add closeButtonFrame (or closeButtonCenter) open CGRect variable to FullScreenSlideshowViewController, so the users will be able to set it, and then viewDidLayoutSubviews will use that value.

@zvonicek
Copy link
Owner

Thanks @yulian948, that's probably the best solution. I added such property.

dirkoswanepoel pushed a commit to dirkoswanepoel/ImageSlideshow that referenced this issue Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants