-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: minor documentation updates and fixes #92
docs: minor documentation updates and fixes #92
Conversation
The BookUI interface had a different key to what was being set in the example code
Given that the plusN function needs to be called, the assumption here is that the plus100 function should also be called as they return the same type
…xample The reason for this is that it looks like a typo and that it should be a string (based on how ngrx and other libraries do it)
This is the same as the npm command but it allows users to copy and paste more easily
Thank you very much for checking the docs and your Contribution. Glad you like the library. We have some cool new features planned for the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, only the one docs change in query.md
is invalid.
…n entry was correct
@zuriscript I'd be really keen to get in touch, if there's more I can contribute here from a code perspective, that would be awesome! What's the best way to get in touch? |
@kerren Thanks again for your contribution. It has been shown that effect objects work very well for structuring and scaling the application. Our upcoming features will primarily focus on enhancing this aspect, including the implementation of a scheduling mechanism for recurring effects and improving interoperability between effects and HTTP calls. New Plugins or plugin ideas are also always welcomed. |
I've been reading through the documentation because I'd like to have a holistic understanding of your library when I use it for my next project. I'm really loving this by the way, it's excellent!
I picked up a few issues as well as some things that I think would be useful to specify in the documentation based on the questions I asked when I read them.
I'm happy to remove some changes if you disagree, let's have discussion about them if you need more context!