Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to community AsyncStorage #3570

Closed
gnprice opened this issue Jul 25, 2019 · 0 comments
Closed

Migrate to community AsyncStorage #3570

gnprice opened this issue Jul 25, 2019 · 0 comments
Labels
P1 high-priority

Comments

@gnprice
Copy link
Member

gnprice commented Jul 25, 2019

This is a followup to the RN v0.59 upgrade #3399. It isn't required before upgrading to v0.60, and might not be for v0.61.

When running unit tests, e.g. with tools/test , or when launching the app with the debugger, the following now goes to the console:

Warning: Async Storage has been extracted from react-native core and will be removed in a future release. It can now be installed and imported from '@react-native-community/async-storage' instead of 'react-native'. See https://github.com/react-native-community/react-native-async-storage

The core module is still there in RN master when I look now.

Marking as a priority, though, because we shouldn't get used to having a big red warning in our tests.

The README doesn't say anything about upgrading from the core module. Hopefully it's easy.
rk-for-zulip added a commit to rk-for-zulip/zulip-mobile that referenced this issue Nov 19, 2019
@rk-for-zulip
store: use @react-native-community/async-storage
355e76d 
Switch to actually using @react-native-community/async-storage.

The module is written in Flow under the hood, but strangely doesn't
expose the Flow types in its standard entry point. We therefore import
directly from the relevant interior file to get proper type
definitions.

This will have to be revisited in the future, as the module is
currently being completely rewritten to use TypeScript.

Fixes zulip#3570.
@gnprice gnprice closed this as completed in 33c87b5 Dec 6, 2019
@gnprice gnprice mentioned this issue Dec 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gnprice