Vendor cgi.FieldStorage #54
Conversation
This is approximately cgi.FieldStorage from Python 3.8, but adjusted to be compatible with both Python 2 and 3, and with some parts removed that BrowserRequest doesn't need. Fixes zopefoundation#39.
By Aron Podrigal; backported from python/cpython#21457.
|
|
||
| # The Python 2.6 cgi module mixes the query string and POST values | ||
| # together. We do not want this. | ||
| env = self._environ | ||
| if self.method == 'POST' and self._environ['QUERY_STRING']: | ||
| if self.method == 'POST' and 'QUERY_STRING' in self._environ: |
There was a problem hiding this comment.
(Note: my comments here are not meant to imply that I prefer this approach to #55)
The comment above about what Python 2.6 cgi module does could be updated to refer to what our vendored copy of the Python 3.8 cgi module does.
There seems to be a problem with the mentioned patch: |
|
According to the contributor agreement vendoring code is not so easy. It reads: "It is assumed that you wrote the software or changes yourself; if other people wrote or changed parts, we will likely need Assignment Agreements from them as well." |
|
I'm withdrawing this in favour of #55. |
This is approximately cgi.FieldStorage from Python 3.8, but adjusted to be compatible with both Python 2 and 3, and with some parts removed that BrowserRequest doesn't need.
Fixes #39.
I also applied the patch from python/cpython#21457 to fix parsing of simple request bodies with Content-Length and no Content-Disposition.
My preference would be to apply #55 instead of this, which I think is much easier to follow and much less code to maintain. However, since the issue has been a bit controversial, I'm posting both so that other people can see what they think.