-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make imports Python 3 compatible #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Are there other fixes required for Python 3 compatibility? Because if not, then I'd like .travis.yml to start testing Python 3, and also setup.py to include the Python version classifiers.
Actually this one is already testable vs Python 3 (I just add to update the bootstrap and drop zope.testing):
I think I do not have the power to add the travis hook. Can somebody do that for me please? |
Travis is enabled for z3c.objpath. |
Can you push another commit so we can see Travis working? E.g. rename *.txt to *.rst for prettier ReST rendering. |
Thanks @jamadden! |
I merged this one, thanks for caring. |
Personally, I'd explicitly declare all supported minor Python versions in setup.py, add Python 3.4 and 3.5 to .travis.yml, and rename *.txt to *.rst before making a new release, to bring z3c.objpath to the standard of other maintained zopefoundation packages. (I'd also add a tox.ini for my own personal convenience, because I prefer running tox locally instead of waiting for Travis results to come in.) But the main thing is to contact one of the current PyPI owners (hi @faassen, @witsch!) and ask them if they can make the release or add you (or anybody else who might volunteer for this duty) as a package owner on PyPI. (Oh, and add url='https://github.com/zopefoundation/z3c.objpath' to setup.py metadata.) Oh, when asking for PyPI permissions it's best to explicitly mention your PyPI username (mine is |
@mgedmin your plan looks reasonable, I will try to put it in practice. BTW I am |
No description provided.