Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ZServer a dependency for py2 only #4

Merged
merged 3 commits into from
May 23, 2018
Merged

make ZServer a dependency for py2 only #4

merged 3 commits into from
May 23, 2018

Conversation

pbauer
Copy link
Member

@pbauer pbauer commented Mar 17, 2018

Fixes #6

@pbauer pbauer requested a review from icemac March 17, 2018 08:17
@ale-rt
Copy link
Member

ale-rt commented Mar 17, 2018

I wonder if we should just drop the requirement for all Python versions.
It seems ZServer is not used in the package at all:

[ale@emily Products.SiteErrorLog]$ grep -R ZServer
setup.py:        'ZServer',

@tseaver
Copy link
Member

tseaver commented Mar 19, 2018

The (really ugly) testSiteErrorLog module imports Zope2 and calls Zope2.startup() at import time, which fails if ZServer is not installed.

That has to be bogus: no reasonable test needs to have the server running.

@icemac
Copy link
Member

icemac commented Mar 23, 2018

@hannosch Is this package intended to run with Zope 4 thus should it be ported to Python 3?

@icemac
Copy link
Member

icemac commented Mar 23, 2018

@ale-rt Running the test on Python 3.6 breaks with ModuleNotFoundError: No module named 'ZServer' as Zope2.startup() is actually ZServer.Zope2.startup().

@ale-rt
Copy link
Member

ale-rt commented Mar 23, 2018

Oh, I see @icemac.
So actually we can move this requirement to the [test] feature, even better fix the test to not use Zope2.startup().
Anyway it seems reasonable to me to merge this one

@ale-rt ale-rt mentioned this pull request Mar 23, 2018
@tseaver
Copy link
Member

tseaver commented Mar 23, 2018

I don't think we should merge as-is. Instead, we should fix the stupid test which starts a server at import time, and remove the ZServer dependency altogether.

@icemac icemac requested a review from tseaver April 4, 2018 07:17
@icemac
Copy link
Member

icemac commented Apr 4, 2018

@tseaver Do you think this is mergeable after my fixes?

@icemac icemac merged commit 3af5f20 into master May 23, 2018
@rbu rbu deleted the python3 branch May 29, 2018 10:12
@rbu rbu mentioned this pull request May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants