-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix importing React/RCTBridgeModule.h #138
Conversation
I can confirm that this fixes my issues on react-native 0.48.1. |
+1 |
@yonahforst do you need any help to release this? |
This commit wasn't quite doing it for me, so I used it as a basis for a standardized approach across all the affected files, please refer to this commit for an example. I can submit a PR if interested. |
@TikiTDO, I think you should raise a PR. I see another PR also addressing this, but its implementation is a bit different. |
This fixes my problem on React-Native v0.48.2. Can this get merged in? |
This fixes my issue when upgrading to React-native 0.48.2 from 0.47.2 Node: 8.4.0 |
Maybe we can make it easy to review for @yonahforst and close 2 or this 3 PRs?
It seems #146 is rock solid, but I am not very comfortable yet with obj-c. |
So if @yonahforst is happy with #146 then #138 and #139 can be closed, that would be great. |
see zoontek/react-native-permissions#138 for another example of this fix
closed in favor of #146. Thanks everyone for your comments. And thanks to @iegik and @huhuanming for #138 & #139 |
If somewhere in code already was import by file name only:
Next import will fail if you try to import by another method:
Becouse paths are different, but import by filename will work every time.