Instant cache refreshing on ZMI-JS changes #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmsdev
requested changes
Dec 15, 2024
Products/zms/__init__.py
Outdated
| # a. write it into separate file and | ||
| # b. create a configuration parameter | ||
| min_fileobj = open(fileobj.name, 'r') | ||
| min_hash = standard.encrypt_password(min_fileobj.read(),hex=True) |
There was a problem hiding this comment.
Why don't you use the python builtin hash()-function and hexlify the result?
Password encryption maybe misleading and change its behaviour.
There was a problem hiding this comment.
the ZMS-builtin function does exactly the required task:
https://github.com/zms-[publishing/ZMS/blob/f5d6275e83ab7d63e33ccf1a03ed2b5ce0997917/Products/zms/conf/metaobj_manager/captcha_lib/captcha_func.py#L46-L57](https://github.com/zms-publishing/ZMS/blob/f5d6275e83ab7d63e33ccf1a03ed2b5ce0997917/Products/zms/standard.py#L622-L645)
Of course the function's name might suggest a special purpose and a limited use. So feel free to apply the python-builtin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/idasm-unibe-ch/unibe-cms/issues/744
ZMI-JS-code changes may be unseen after deployment due to proxy caching. A hash value of the minified ZMI-JS code (created on Zope start) will refresh the proxy caching of the minfied file
/++resource++zms_/zms-all.min.js.The code proposal determines the hash value from the freshly created
zms-all.min.js-file and writes it aszms-all.min.js.hashinto the file system andjs_min.hashThus it is easy to
zmscontext.getConfProperty('js_min.hash')Any code status will result in a specific hash-value ...
... and create a new URL for zms-all.min.js: