update .name properties of `String#{trimStart, trimEnd , trimLeft, …

…trimRight}` by proposal, mark mongolian vowel separator as non-whitespace in one more place
zloirock · May 5, 2018 · 15c790f · 15c790f
1 parent 8d6f675
commit 15c790f
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/packages/core-js/internals/string-trim.js b/packages/core-js/internals/string-trim.js
@@ -3,14 +3,14 @@ var requireObjectCoercible = require('../internals/require-object-coercible');
 var fails = require('../internals/fails');
 var whitespaces = require('../internals/whitespaces');
 var space = '[' + whitespaces + ']';
-var non = '\u200b\u0085';
+var non = '\u200b\u0085\u180e';
 var ltrim = RegExp('^' + space + space + '*');
 var rtrim = RegExp(space + space + '*$');
 
 var exporter = module.exports = function (KEY, exec, ALIAS) {
   var exported = {};
   var FORCED = fails(function () {
-    return !!whitespaces[KEY]() || non[KEY]() != non;
+    return !!whitespaces[KEY]() || non[KEY]() != non || whitespaces[KEY].name !== KEY;
   });
   var fn = exported[KEY] = FORCED ? exec(trim) : whitespaces[KEY];
   if (ALIAS) exported[ALIAS] = fn;

diff --git a/packages/core-js/modules/esnext.string.trim-left.js b/packages/core-js/modules/esnext.string.trim-left.js
@@ -1,8 +1,8 @@
 'use strict';
 // `String.prototype.{ trimLeft, trimStart }` methods
 // https://github.com/tc39/ecmascript-string-left-right-trim
-require('../internals/string-trim')('trimLeft', function (internalTrim) {
-  return function trimLeft() {
+require('../internals/string-trim')('trimStart', function (internalTrim) {
+  return function trimStart() {
     return internalTrim(this, 1);
   };
-}, 'trimStart');
+}, 'trimLeft');
diff --git a/packages/core-js/modules/esnext.string.trim-right.js b/packages/core-js/modules/esnext.string.trim-right.js
@@ -1,8 +1,8 @@
 'use strict';
 // `String.prototype.{ trimRight, trimEnd }` methods
 // https://github.com/tc39/ecmascript-string-left-right-trim
-require('../internals/string-trim')('trimRight', function (internalTrim) {
-  return function trimRight() {
+require('../internals/string-trim')('trimEnd', function (internalTrim) {
+  return function trimEnd() {
     return internalTrim(this, 2);
   };
-}, 'trimEnd');
+}, 'trimRight');
diff --git a/tests/tests/esnext.string.trim-left.js b/tests/tests/esnext.string.trim-left.js
@@ -4,7 +4,7 @@ QUnit.test('String#trimLeft', assert => {
   const { trimLeft } = String.prototype;
   assert.isFunction(trimLeft);
   assert.arity(trimLeft, 0);
-  assert.name(trimLeft, 'trimLeft');
+  assert.name(trimLeft, 'trimStart');
   assert.looksNative(trimLeft);
   assert.nonEnumerable(String.prototype, 'trimLeft');
   assert.strictEqual(' \n  q w e \n  '.trimLeft(), 'q w e \n  ', 'removes whitespaces at left side of string');
@@ -20,7 +20,7 @@ QUnit.test('String#trimStart', assert => {
   const { trimStart } = String.prototype;
   assert.isFunction(trimStart);
   assert.arity(trimStart, 0);
-  assert.name(trimStart, 'trimLeft');
+  assert.name(trimStart, 'trimStart');
   assert.looksNative(trimStart);
   assert.nonEnumerable(String.prototype, 'trimStart');
   assert.same(trimStart, String.prototype.trimLeft, 'same #trimLeft');

diff --git a/tests/tests/esnext.string.trim-right.js b/tests/tests/esnext.string.trim-right.js
@@ -4,7 +4,7 @@ QUnit.test('String#trimRight', assert => {
   const { trimRight } = String.prototype;
   assert.isFunction(trimRight);
   assert.arity(trimRight, 0);
-  assert.name(trimRight, 'trimRight');
+  assert.name(trimRight, 'trimEnd');
   assert.looksNative(trimRight);
   assert.nonEnumerable(String.prototype, 'trimRight');
   assert.strictEqual(' \n  q w e \n  '.trimRight(), ' \n  q w e', 'removes whitespaces at right side of string');
@@ -20,7 +20,7 @@ QUnit.test('String#trimEnd', assert => {
   const { trimEnd } = String.prototype;
   assert.isFunction(trimEnd);
   assert.arity(trimEnd, 0);
-  assert.name(trimEnd, 'trimRight');
+  assert.name(trimEnd, 'trimEnd');
   assert.looksNative(trimEnd);
   assert.nonEnumerable(String.prototype, 'trimEnd');
   assert.same(trimEnd, String.prototype.trimRight, 'same #trimRight');