fix(lifecycle): detect binding.gyp for default install lifecycle

[caleblloyd]

This is a fix to detect if binding.gyp exists in a package without an install lifecycle script, and if so adds the default install lifecycle script

I opted to check for binding.gyp using statAsync instead of readPkgJson.extras because the only thing needed here was binding.gyp detection, not everything else provided by readPkgJson.extras

I looked at adding a test but was unable to come up with a good way to make a fake binding.gyp that could output a detectable string. I'm open for suggestions though.

[zkat]

Thanks for this patch! I'm glad you found this and fixed it 💚

The patch looks good, but I'm wondering if it makes sense to move this to the updateJson method -- that's usually used to add the _from field but you can use it to do the binding.gyp check.

The main difference is that buildTree happens serially, so those statAsync calls are going to block iteration.

My strongest preference is to have pacote itself detect binding.gyp on extract, which would allow us to skip the stats altogether (they're pretty expensive, performance-wise, and this one is going to be very common)

[caleblloyd]

I've moved the logic to updateJson and even figured out how to write a test for it 🎉 Changes are ready for review

[zkat]

Awesome! And I tested this locally and it seems to not have any noticeable performance impact. Thanks a bunch for this and the changes! 🚢

[zkat]

I've merged this and it's been released as [email protected]. It should be available in the next npm release.

[caleblloyd]

Great, thanks! I've patched this fix into my workflow and it seems to fix the original issue with no side effects. Looking forward to pulling it down in the next npm release!