Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update footer.html to always open link to hugo-scroll in new window #121

Merged
merged 2 commits into from
Mar 26, 2023
Merged

Update footer.html to always open link to hugo-scroll in new window #121

merged 2 commits into from
Mar 26, 2023

Conversation

ottlinger
Copy link
Contributor

Modify footer to always open link to this repo in a new tab.

@ottlinger
Update footer.html to always open link to hugo-scroll in new window
41e9f95 
Modify footer to always open link to this repo in a new tab.
@ottlinger
Copy link
Contributor Author

@zjedi not sure about what to do concerning the security warning.

@zjedi
Copy link
Owner

zjedi commented Mar 26, 2023

target="_blank" rel="noopener"> something like this should fix it

@ottlinger
Update footer.html
ab6c1b3 
Add rel=noopener to try to fix security warning.
@ottlinger
Copy link
Contributor Author

Not sure if
rel=”noopener noreferrer” would be the best solution, but I leave this decision up to you :)

@zjedi zjedi merged commit 26ddfdc into zjedi:master Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ottlinger @zjedi