Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref/reduce eval nix interface #89

Merged
merged 4 commits into from
Jul 13, 2022
Merged

ref/reduce eval nix interface #89

merged 4 commits into from
Jul 13, 2022

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented May 26, 2022 •
edited
Loading

  • ref: reduce eval.nix contract
  • ref: reduce eval.nix contract forther
  • ref: reduce eval.nix contract even further
  • ref: transparent eval.nix contract

nrdxp
nrdxp approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@nrdxp nrdxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaofengli
Copy link
Owner

@blaggacao Could you rebase after #96?

blaggacao added 3 commits July 9, 2022 15:41
@blaggacao
ref: reduce eval.nix contract
c82517f 
- documentation contratcts can now bypass the eval.nix iface
- enabled by:9bd5e7bb2540664fe1c728c85f80375fe0cbf9fa
@blaggacao
ref: reduce eval.nix contract forther
83a919b 
- module export contratcts can now bypass the eval.nix iface
- enabled by:9bd5e7bb2540664fe1c728c85f80375fe0cbf9fa
@blaggacao
ref: reduce eval.nix contract even further
e309b2d 
- meta and evalAll contracts are found to be not consumed
@blaggacao blaggacao force-pushed the ref/reduce-eval-nix-interface branch from f31d187 to 46b7334 Compare July 9, 2022 20:45
@blaggacao
ref: transparent eval.nix contract
b3ca4b1 
- at least to my eyes, this code formatting gives a better view about
  the gist of the eval.nix interface
@blaggacao blaggacao force-pushed the ref/reduce-eval-nix-interface branch from 46b7334 to b3ca4b1 Compare July 9, 2022 21:04
@zhaofengli
Copy link
Owner

Thanks! I'll make a decision about a public eval interface in a bit.

@zhaofengli zhaofengli merged commit 07efd58 into zhaofengli:main Jul 13, 2022
@blaggacao blaggacao deleted the ref/reduce-eval-nix-interface branch July 13, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrdxp nrdxp nrdxp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blaggacao @zhaofengli @nrdxp