Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I've tested this repo with a faster optical flow and it works! #7

Closed
chrisuehlinger opened this issue Sep 22, 2017 · 15 comments
Closed

Comments

@chrisuehlinger
Copy link

Not sure if you're still following up on this project, but I figured I'd note this for you just in case.

Going off of the advice in your README (that we don't necessarily need deepflow, just optical flow), I found another project that is easy to build (it has 2 deps that can be installed with apt-get) and that produces .flo files that work with your Torch scripts. The project can be found at https://github.com/tikroeger/OF_DIS and the executable that works here is run_OF_RGB.

I used a 1 second 360p video to benchmark the new flow calculator (on an EC2 P2 instance). I saw an improvement from 15 minutes using deepflow to a couple seconds using run_OF_RGB. This is a real game changer for me in terms of being able to produce videos more easily, and I just wanted to share it with a project that has helped me out a lot. Cheers!

@zeruniverse
Copy link
Owner

zeruniverse commented Sep 22, 2017 via email

@chrisuehlinger
Copy link
Author

I'm going to try a couple videos first just to make sure it meets a similar standard of quality to deepflow, but if it does, I'll make a PR sometime in the next week with installation instructions.

@zeruniverse
Copy link
Owner

zeruniverse commented Sep 22, 2017 via email

@zeruniverse
Copy link
Owner

Any updates on this?

@luismqueral
Copy link

+1 @chrisuehlinger would love to connect if you already have this working!

@zeruniverse
Copy link
Owner

zeruniverse commented Oct 22, 2017 via email

@zeruniverse
Copy link
Owner

No reply for a long time. If anyone figured it out, please submit a PR

@schwittlick
Copy link
Contributor

Hey @zeruniverse

I've had a go at this and it indeed works! And the other optical flow is by magnitudes faster. On the downside, it's not as stable as deepflow. I'll have a look whether I can parametrize it a bit, but wanted to share some progress here. Compiling and using run_OF_RGB (https://github.com/tikroeger/OF_DIS) is actually very simple.

Here's the diff for run-deepflow.sh: schwittlick@1a81b07

Can you give me a hint what the deepmatching-static is exactly doing in this workflow? (I've removed it, cause it's very slow, too)

Here's two samples (better download the file and watch, vimeo compression artifacts might make the difference hard to spot):
deepflow: https://vimeo.com/246746437
run_OF_RGB: https://vimeo.com/246746400

My run_OF_RGB binary is dynamically linked at the moment, so I'll see to build it statically, so we could eventually add it to this repo?

Thanks for this, by the way, I'm using this for some video works and love it!

Marcel

@schwittlick
Copy link
Contributor

PS: I've added some parameters to run_OF_RGB: schwittlick@32d0f81

This results in much better optical flow quality and looks the same like deepflow. Amazing!

@zeruniverse
Copy link
Owner

zeruniverse commented Dec 12, 2017 via email

@schwittlick
Copy link
Contributor

Unfortunately I'm not able to compile OF_DIS as a static executable, so it will not find the shared libraries on other people's systems...

For example

libopencv_highgui.so.2.4 => /usr/local/lib/libopencv_highgui.so.2.4 (0x00007fb06ff09000)
libopencv_imgproc.so.2.4 => /usr/local/lib/libopencv_imgproc.so.2.4 (0x00007fb06f9fa000)
libopencv_core.so.2.4 => /usr/local/lib/libopencv_core.so.2.4 (0x00007fb06f40b000)
libcudart.so.8.0 => /usr/local/cuda/lib64/libcudart.so.8.0 (0x00007fb06951a000)
libz.so.1 => /mnt/drive1/tools/anaconda2/lib/libz.so.1 (0x00007fb069304000)

Not sure it's a good idea to merge this.. Any suggestion?

@zeruniverse
Copy link
Owner

zeruniverse commented Dec 12, 2017 via email

@schwittlick
Copy link
Contributor

Hmm.. I doubt that's a good idea. But I can't say for sure. I wonder why a cuda dependency is in there anyhow.. I will do some tests and report back. As an alternative we could write up a little tutorial in the readme and that's it.-

@zeruniverse
Copy link
Owner

zeruniverse commented Dec 12, 2017 via email

@schwittlick
Copy link
Contributor

Interestingly, the dynamic executable worked out of the box on my other computer. pr'ing ;)

zeruniverse added a commit that referenced this issue Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants