forked from russnash/Kaboom
-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nullref #75
Merged
Merged
fix nullref #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zer0Kerbal
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤗
zer0Kerbal
added
issue: code
issue type
type: fix
Iterations on existing features or infrastructure.
type: pull request
upstream or side stream
state: approved
Approved to proceed.
labels
Mar 24, 2022
zer0Kerbal
added a commit
that referenced
this pull request
Mar 25, 2022
### fix nullref * thank you @yalov * closes #74 - [Bug 🐞]: No Booms :( 🧯 * closes #72 - Missing #BOOM-KaboomAction = Kaboom! localization string ### Repo refresh * Update all support files * Add GitHub pages support ### Localization * Add strings for [InstallChecker.cs] * [#BOOM-IC-01] = Incorrect <<1>> v<<2>> installation.\n<<1>> has been installed incorrectly and will not function properly. All files should be located in KSP/GameData/<<3>>. Do not move any files from inside that folder.\n\nIncorrect path(s):\n<<4>> ### Code * Update * [Version.tt] v2.0.2.1 * [InstallChecker.cs] v2.1.0.0 ### docs/ * Create * docs/ * [404.md] * [Attributions.md] * [ManualInstallation.md] * [LegalMumboJumbo.md] * [Localizations.md] * Code/ * [Kaboom.xml] * LegalMumboJumbo/ * [FORUM-01.png] * [FORUM-02.png] * [FORUM-03.png] * [License.md] * ReleaseNotes/ * [1.2.0.0.md] * [1.2.1.0.md] * [1.3.0.0.md] * [1.3.99.0.md] * [1.3.99.1.htm] * [1.3.99.2.htm] * [1.3.99.2-beta-3.md] * [1.4.0.0.md] * [1.4.0.1.md] * [1.4.1.0.md] ### Documentation * Updated * [readme.md] v1.6.6.0 * converted [changelog.cfg] to [changelog.md] * _releasenotes v1.3.1.1 * [Kaboom.version] * update minimum KSP version * [_release.json] to schema v1.0.3.0 ### Status * Issues * closes #78 - 1.4.10.0 Social Media * closes #77 - 1.4.10.0 Update Documentation * closes #76 - 1.4.10.0 Verify Legal Mumbo Jumbo * closes #73 - Kaboom Version 1.4.10.0-prerelease - <Missing Booms?> * Bugs * closes #71 - add missed #BOOM-KaboomAction - contributed by yalov * closes #72 - Missing #BOOM-KaboomAction = Kaboom! localization string * closes #74 - [Bug 🐞]: No Booms :( 🧯 * closes #75 - fix nullref - contributed by yalov
zer0Kerbal
added a commit
that referenced
this pull request
Mar 25, 2022
## Version 1.4.1.0 - `<Missing Booms?>` * 23 Mar 2022 * for KSP 1.12.3 ### fix nullref * thank you @yalov * closes #74 - [Bug 🐞]: No Booms :( 🧯 * closes #72 - Missing #BOOM-KaboomAction = Kaboom! localization string ### Repo refresh * Update all support files * Add GitHub pages support ### Localization * Add strings for [InstallChecker.cs] * [#BOOM-IC-01] = Incorrect <<1>> v<<2>> installation.\n<<1>> has been installed incorrectly and will not function properly. All files should be located in KSP/GameData/<<3>>. Do not move any files from inside that folder.\n\nIncorrect path(s):\n<<4>> ### Code * Update * [Version.tt] v2.0.2.1 * [InstallChecker.cs] v2.1.0.0 * [AssemblyInfo.cs ### docs/ * Create * docs/ * [404.md] * [Attributions.md] * [ManualInstallation.md] * [LegalMumboJumbo.md] * [Localizations.md] * Code/ * [Kaboom.xml] * LegalMumboJumbo/ * [FORUM-01.png] * [FORUM-02.png] * [FORUM-03.png] * [License.md] * ReleaseNotes/ * [1.2.0.0.md] * [1.2.1.0.md] * [1.3.0.0.md] * [1.3.99.0.md] * [1.3.99.1.htm] * [1.3.99.2.htm] * [1.3.99.2-beta-3.md] * [1.4.0.0.md] * [1.4.0.1.md] * [1.4.1.0.md] ### Documentation * Updated * [readme.md] v1.6.6.0 * converted [changelog.cfg] to [changelog.md] * _releasenotes v1.3.1.1 * [Kaboom.version] * update minimum KSP version * [_release.json] to schema v1.0.3.0 ### Status * Issues * closes #78 - 1.4.10.0 Social Media * closes #77 - 1.4.10.0 Update Documentation * closes #76 - 1.4.10.0 Verify Legal Mumbo Jumbo * closes #73 - Kaboom Version 1.4.10.0-prerelease - <Missing Booms?> * Bugs * closes #71 - add missed #BOOM-KaboomAction - contributed by yalov * closes #72 - Missing #BOOM-KaboomAction = Kaboom! localization string * closes #74 - [Bug 🐞]: No Booms :( 🧯 * closes #75 - fix nullref - contributed by yalov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
issue: code
issue type
state: approved
Approved to proceed.
type: fix
Iterations on existing features or infrastructure.
type: pull request
upstream or side stream
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #74