This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 130
ZF3 #213
Merged
Merged
ZF3 #213
Changes from 10 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
2089b51
Update ZDT for use with modern ZF components
07fc76c
use PSR4 autoloader
69cc60c
Merge branch 'master' of github.com:alex-oleshkevich/ZendDeveloperTools
dd79364
Merge branch 'master' of github.com:alex-oleshkevich/ZendDeveloperTools
a41ee4c
Merge branch 'master' of github.com:alex-oleshkevich/ZendDeveloperTools
183d6e8
Remove phpunit.xml
f2dc619
remove 5.3 and 5.4 versions of php from travis
bf4d652
Update composer.json
alex-oleshkevich e063b7d
remove Module::getAutoloaderConfig() as https://github.com/zendframew…
samsonasik 9aaca7d
update zend-mvc dependency
samsonasik 3125403
short array syntax
samsonasik cb1b467
another short array syntax
samsonasik 6f272e5
remove php 7 from allow_failures
samsonasik 616ba68
uses "test" instead of "tests" folder for consistency
samsonasik 50cf2f2
psr-4 autoloader
samsonasik c47b1db
use phpunit: ~4 || ~5
samsonasik a2554cf
update include module.config.php path
samsonasik 75f6fb7
use ZendDeveloperToolsTest for test
samsonasik 498cb0d
one empty line at the end of .travis.yml
samsonasik 891d3e8
remove whitespace in ToolbarListener
samsonasik 6981ee0
another white character
samsonasik 8d0c9be
remove duplicated autoload-dev
samsonasik 219eb58
added php-cs check and checks for lowest, locked, latest in .travis.yml
samsonasik ca71be4
cs fix
samsonasik 0419000
whitespace fix
samsonasik f554d92
commit composer.lock
samsonasik 3232f51
remove DEPS=locked from php 5.5
samsonasik fdaaf23
re-update composer.lock
samsonasik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,6 @@ | ||
language: php | ||
|
||
php: | ||
- 5.3.3 | ||
- 5.4 | ||
- 5.5 | ||
- 5.6 | ||
- 7 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,9 +11,8 @@ | |
|
||
use Zend\EventManager\Event; | ||
use Zend\EventManager\SharedEventManagerInterface; | ||
use Zend\EventManager\SharedListenerAggregateInterface; | ||
use Zend\ServiceManager\Exception\ServiceNotFoundException; | ||
use ZendDeveloperTools\Collector\CollectorInterface; | ||
use ZendDeveloperTools\Collector\EventCollectorInterface; | ||
use ZendDeveloperTools\Profiler; | ||
|
||
/** | ||
|
@@ -22,10 +21,10 @@ | |
* @author Mark Garrett <[email protected]> | ||
* @since 0.0.3 | ||
*/ | ||
class EventLoggingListenerAggregate implements SharedListenerAggregateInterface | ||
class EventLoggingListenerAggregate | ||
{ | ||
/** | ||
* @var \ZendDeveloperTools\Collector\EventCollectorInterface[] | ||
* @var EventCollectorInterface[] | ||
*/ | ||
protected $collectors; | ||
|
||
|
@@ -37,7 +36,7 @@ class EventLoggingListenerAggregate implements SharedListenerAggregateInterface | |
/** | ||
* Constructor. | ||
* | ||
* @param \ZendDeveloperTools\Collector\EventCollectorInterface[] $collectors | ||
* @param EventCollectorInterface[] $collectors | ||
* @param string[] $identifiers | ||
*/ | ||
public function __construct(array $collectors, array $identifiers) | ||
|
@@ -61,7 +60,9 @@ function ($identifier) { | |
*/ | ||
public function attachShared(SharedEventManagerInterface $events) | ||
{ | ||
$events->attach($this->identifiers, '*', array($this,'onCollectEvent'), Profiler::PRIORITY_EVENT_COLLECTOR); | ||
foreach ($this->identifiers as $id) { | ||
$events->attach($id, '*', array($this,'onCollectEvent'), Profiler::PRIORITY_EVENT_COLLECTOR); | ||
} | ||
} | ||
|
||
/** | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,15 +89,11 @@ public function __construct($viewRenderer, Options $options) | |
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function attach(EventManagerInterface $events) | ||
public function attach(EventManagerInterface $events, $priority = 1) | ||
{ | ||
$this->listeners[] = $events->attach( | ||
ProfilerEvent::EVENT_COLLECTED, | ||
array($this, 'onCollected'), | ||
Profiler::PRIORITY_TOOLBAR | ||
); | ||
$this->listeners[] = $events->getSharedManager()->attach('profiler', ProfilerEvent::EVENT_COLLECTED, array($this, 'onCollected'), Profiler::PRIORITY_TOOLBAR); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we use please short array syntax? |
||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please remove white characters above |
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
short array syntax plz