Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Adapt code for use with modern EM. #210

Closed
wants to merge 8 commits into from
Closed

Adapt code for use with modern EM. #210

wants to merge 8 commits into from

Conversation

alex-oleshkevich
Copy link
Contributor

No noticeable breaks found, code adopted for use with EM 3.
Also changed autoloader to PSR-4 to make it more constistent with ZF.

Solves #207

"zendframework/zend-debug": "2.*",
"zendframework/zend-view": "2.*"
"php": "^5.5 || ^7.0",
"zendframework/zend-mvc": "^2.7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use "^2.7 || ^3.0.0@dev" in favor of zendframework/ZendSkeletonApplication#329 to avoid this error:

$ composer update
You are running composer with xdebug enabled. This has a major impact on runtime performance. See https://getcomposer.org/xdebug
Loading composer repositories with package information
Updating dependencies (including require-dev)                             
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Can only install one of: zendframework/zend-mvc[2.7.x-dev, 3.0.x-dev].
    - Can only install one of: zendframework/zend-mvc[2.7.x-dev, 3.0.x-dev].
    - zendframework/zend-developer-tools dev-zf3 requires zendframework/zend-mvc ^2.7 -> satisfiable by zendframework/zend-mvc[2.7.x-dev].
    - Installation request for zendframework/zend-developer-tools dev-zf3 -> satisfiable by zendframework/zend-developer-tools[dev-zf3].
    - Installation request for zendframework/zend-mvc ^3.0.0@dev -> satisfiable by zendframework/zend-mvc[3.0.x-dev].

@alex-oleshkevich
Copy link
Contributor Author

Changed

@samsonasik
Copy link
Contributor

tested with zend-mvc ^3.0.0@dev used zendframework/ZendSkeletonApplication#329 👍
For zend-version usage, just in case we won't use it again, it may rely on Application\Module::VERSION ..

but for now, @Ocramius I think it ready for merge with may be create new tag /cc @weierophinney

@samsonasik
Copy link
Contributor

@weierophinney @Ocramius this needs to be merged if zendframework/ZendSkeletonApplication#329 merged ;)

@samsonasik
Copy link
Contributor

as zendframework/ZendSkeletonApplication#329 merged, I think it merge-able ;). The ZendDeveloperTools will support v2 and v3 after it merged

"zendframework/zend-debug": "2.*",
"zendframework/zend-view": "2.*"
"php": "^5.5 || ^7.0",
"zendframework/zend-mvc": "^2.7 || ^3.0.0@dev",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should ready to use: "^2.7 || ^3.0.0",

@aight8
Copy link

aight8 commented Jun 3, 2016

Any updates?

@alex-oleshkevich
Copy link
Contributor Author

@froschdesign, what updates do you wait from me?

@samsonasik
Copy link
Contributor

ping @weierophinney @Ocramius

@froschdesign
Copy link
Member

@alex-oleshkevich
Please remove ZendDeveloperTools\Module::getAutoloaderConfig().

@samsonasik
Copy link
Contributor

@froschdesign I think you can doing that on merge in case @alex-oleshkevich doesn't have a chance to update it /cc @Ocramius @weierophinney :)

samsonasik added a commit to samsonasik/ZendDeveloperTools that referenced this pull request Jun 24, 2016
@samsonasik samsonasik mentioned this pull request Jun 24, 2016
Merged
@samsonasik
Copy link
Contributor

@alex-oleshkevich I cherry-picked your commits in new PR #213 with include I and @froschdesign feedbacks patches, hope will get merged soon.

//cc @Ocramius @weierophinney

@alex-oleshkevich
Copy link
Contributor Author

ok. then i close that PR as commits moved to another one.

weierophinney added a commit that referenced this pull request Jun 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants