This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Argument 1 passed to ZendDeveloperTools\Listener\EventLoggingListenerAggregate::onCollectEvent() must be an instance of Zend\EventManager\Event #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,5 +23,5 @@ | |||
| * @param string $id | |||
| * @param Event $event | |||
| */ | |||
| public function collectEvent($id, Event $event); | |||
| public function collectEvent($id, EventInterface $event); | |||
There was a problem hiding this comment.
This change can't be implemented until version 2.0.0 of the module, as it is a major BC break
There was a problem hiding this comment.
And yes, it is a major mistake in designing this interface in first place :-(
There was a problem hiding this comment.
Ah no problem; I thought as much :-)
|
need rebase |
|
I tried to use the |
weierophinney
added a commit
that referenced
this pull request
Dec 26, 2019
|
Merged to develop for release with 2.0.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been using a custom event implementing interface
Zend\EventManager\EventInterfacewithout extending from the classZend\EventManager\Event. When such and event is triggered within my application and ZendDeveloperTools is enabled, I receive the following exception message:The following classes currently type hint on
Zend\EventManager\Event; I propose these are updated to useZend\EventManager\EventInterfaceinstead.