Introduce a mechanism for contextualizing panics #21973
Open
+139
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a way for callsites throughout the Zed client to pass context to our custom panic hook (defined in
crates/zed/src/reliability.rs
) and ultimately to#panics
in the Zed Slack. When we see a particular panic backtrace repeatedly and the cause isn't immediately obvious, this allows us to update the code to package some additional contextual information when that panic occurs in the future. It combines well withcatch_unwind
for cases where we want to stop the panic from crashing Zed but still get a telemetry report about it, since the panic hook is called even for panics that are caught. Usage:Release Notes: