Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty title in Recent Projects #21952

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

huacnlee
Copy link
Contributor

@huacnlee huacnlee commented Dec 13, 2024

Close #13595

Release Notes:

  • Fixed empty title in Recent Projects.

Before After
SCR-20241213-nzxr image

This is because the LocalPathsOrder get empty list.

[crates/recent_projects/src/recent_projects.rs:385:9] &location = Local(
    LocalPaths(
        [
            "/Users/jason/Library/Application Support/Zed/prettier/node_modules",
        ],
    ),
    LocalPathsOrder(
        [],
    ),
)
[crates/recent_projects/src/recent_projects.rs:386:9] &paths = [
    "~/Library/Application Support/Zed/prettier/node_modules",
]
[crates/recent_projects/src/recent_projects.rs:385:9] &location = Local(
    LocalPaths(
        [
            "/Users/jason/github/tree-sitter-csv",
        ],
    ),
    LocalPathsOrder(
        [],
    ),
)
[crates/recent_projects/src/recent_projects.rs:386:9] &paths = [
    "~/github/tree-sitter-csv",
]
[crates/recent_projects/src/recent_projects.rs:385:9] &location = Local(
    LocalPaths(
        [
            "/Users/jason/work/autocorrect/autocorrect-website/dist",
        ],
    ),
    LocalPathsOrder(
        [],
    ),
)

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 13, 2024
@huacnlee huacnlee marked this pull request as draft December 13, 2024 08:47
@huacnlee huacnlee force-pushed the fix-empty-title-in-recent-projects branch from 6ccca48 to e13e2af Compare December 13, 2024 09:22
@huacnlee huacnlee marked this pull request as ready for review December 13, 2024 09:22
@Angelk90
Copy link

@huacnlee : Why is the height so high of the elements, are there elements before to match this height?
Screenshot 2024-12-13 alle 11 33 52

@huacnlee
Copy link
Contributor Author

huacnlee commented Dec 13, 2024

@Angelk90 There have many items, not only 1. Them just not have title to display.

@Angelk90
Copy link

@huacnlee : What happens when the dir no longer exists?

@CharlesChen0823
Copy link
Contributor

see #16159

@huacnlee
Copy link
Contributor Author

@Angelk90 The folder is still exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty items in recent project selector
3 participants