-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cosmic-text to version 0.12.1 #15748
Update cosmic-text to version 0.12.1 #15748
Conversation
We require contributors to sign our Contributor License Agreement, and we don't have @florenzthedev on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
I don't really see where the fix you mentioned is included? pop-os/cosmic-text@542b20c...58c2ccd In any case, if you'd like to update cosmic-text I'd upgrade to |
@apricotbucket28 the change downgrades fontdb to 0.16, which was the last version before the regression (which was introduced by the performance improvement). I am currently waiting for this fix to merge before opening PRs on cosmic-text (and eventually here): RazrFalcon/fontdb#68 |
@jcdickinson Thanks for this! It looks like the fontdb change has been reverted, is there a newer version of cosmic text without the regression and with the performance improvements? |
It seems like this is waiting on pop-os/cosmic-text#296 to land. I guess the Cosmic team is busy since they launched their DE alpha not too long ago. |
This PR will also need to update resvg to 0.43, as that has a transitive dependency to fontdb. |
That shouldn't be necessary, since the text shaping feature of resvg is disabled in GPUI. |
Closing this for now, but let's reland it when upstream is in a good place. |
Summary:
The update fixes an issue where certain system fonts are missing/not usable inside of Zed. After doing some debugging I found this was an issue with cosmic-text and was fixed between cosmic-text versions 0.11 and 0.12.
Release Notes: