Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cosmic-text to version 0.12.1 #15748

Closed

Conversation

florenzthedev
Copy link

Summary:

The update fixes an issue where certain system fonts are missing/not usable inside of Zed. After doing some debugging I found this was an issue with cosmic-text and was fixed between cosmic-text versions 0.11 and 0.12.

Release Notes:

  • Bumped cosmic-text version to 0.12.1
  • Fixes Issue #14324

Copy link

cla-bot bot commented Aug 3, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @florenzthedev on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@florenzthedev
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Aug 3, 2024
Copy link

cla-bot bot commented Aug 3, 2024

The cla-bot has been summoned, and re-checked this pull request!

@apricotbucket28
Copy link
Contributor

apricotbucket28 commented Aug 3, 2024

I don't really see where the fix you mentioned is included? pop-os/cosmic-text@542b20c...58c2ccd
It also seems like you forgot to git add Cargo.lock, since fontdb got downgraded in cosmic-text (which unnecessarily reverses a performance optimization when loading fonts).

In any case, if you'd like to update cosmic-text I'd upgrade to 6f78d23, which includes multiple bug fixes by switching to newer versions of dependencies.
And I'd also cargo update -p swash

@florenzthedev florenzthedev marked this pull request as draft August 3, 2024 21:57
@jcdickinson
Copy link
Contributor

@apricotbucket28 the change downgrades fontdb to 0.16, which was the last version before the regression (which was introduced by the performance improvement). I am currently waiting for this fix to merge before opening PRs on cosmic-text (and eventually here): RazrFalcon/fontdb#68

@ConradIrwin
Copy link
Member

@jcdickinson Thanks for this! It looks like the fontdb change has been reverted, is there a newer version of cosmic text without the regression and with the performance improvements?

@ConradIrwin ConradIrwin self-assigned this Aug 22, 2024
@apricotbucket28
Copy link
Contributor

It seems like this is waiting on pop-os/cosmic-text#296 to land. I guess the Cosmic team is busy since they launched their DE alpha not too long ago.
Maybe cosmic-text could be pinned to the commit hash from the PR?

@jcdickinson
Copy link
Contributor

This PR will also need to update resvg to 0.43, as that has a transitive dependency to fontdb.

@apricotbucket28
Copy link
Contributor

This PR will also need to update resvg to 0.43, as that has a transitive dependency to fontdb.

That shouldn't be necessary, since the text shaping feature of resvg is disabled in GPUI.

@ConradIrwin
Copy link
Member

Closing this for now, but let's reland it when upstream is in a good place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants