Add Legacy target-access-mode to enable upgrade from pre 0.12.17 version
#523
Conversation
AlexanderYastrebov
force-pushed
the
legacy-target-access-mode
branch
from
7aab79c to
3176edd
Compare
AlexanderYastrebov
force-pushed
the
legacy-target-access-mode
branch
from
4381b72 to
7a7c527
Compare
|
Are you still working on this @AlexanderYastrebov ? |
|
@jbilliau-rcd Hi, we need some effort to push it forward, currently I am overwhelmed by the backlog |
|
hey @AlexanderYastrebov , just checking in, I know you prob swamped. This still in limbo? |
|
@jbilliau-rcd soon (~2nd week of October IIRC) we will have more time, because of internal code freeze. Sorry for the delay. :( |
|
@szuecs hey, just checking in; how we looking? |
|
Let's ask @AlexanderYastrebov |
|
hey @AlexanderYastrebov , looks like the only thing holding this up is some code coverage tests? |
|
@jbilliau-rcd this is not required. Can you open the PR as non-draft, please? |
|
@szuecs it's not my PR, I have no access to do that. Also, I'm not sure if @AlexanderYastrebov if fully done or not, maybe he left it in draft for a reason, was still vetting stuff out? Not sure. |
|
@jbilliau-rcd oh, my bad will try to ask him to finish it up. |
AlexanderYastrebov
force-pushed
the
legacy-target-access-mode
branch
from
7a7c527 to
8a5eef4
Compare
…` version Before version `0.12.17` loadbalancer target group target type was not specified and defaulted to `instance` in CloudFormation, see https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticloadbalancingv2-targetgroup.html#cfn-elasticloadbalancingv2-targetgroup-targettype PR #461 introduced AWS CNI mode and configured target group target type either to `ip` or `instance`. Changing target type from unset to `instance` in Cloudformation triggers target group re-creation which makes it impossible to upgrade from pre `0.12.17` without downtime. This change: - makes `target-access-mode` flag required to force users to choose proper value - introduces a new `Legacy` option that does not set target type and thus enables upgrade from pre `0.12.17`. Fixes #507 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
legacy-target-access-mode
branch
from
8a5eef4 to
c21ce70
Compare
|
Looks like this is all ready to go? @szuecs are you someone who can review and merge? I appreciate the work btw; we have 200 clusters using this controller and so this is a HUGE burden off our shoulders since we have to upgrade to avoid the BoundServiceAccountToken expiration issue. |
|
👍 |
1 similar comment
|
👍 |
Before version
0.12.17loadbalancer target group target type was notspecified and defaulted to
instancein CloudFormation, seehttps://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticloadbalancingv2-targetgroup.html#cfn-elasticloadbalancingv2-targetgroup-targettype
PR #461 introduced AWS CNI mode and configured target group target type
either to
iporinstance.Changing target type from unset to
instancein Cloudformation triggers targetgroup re-creation which makes it impossible to upgrade from pre
0.12.17without downtime.This change:
target-access-modeflag required to force users to choose proper valueLegacyoption that does not set target type and thus enables upgrade from pre0.12.17.Fixes #507
Signed-off-by: Alexander Yastrebov [email protected]