Fix duplicate breadcrumbs #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the event the first breadcrumb's name wasn't linked, that breadcrumb's name object was mutated into the full breadcrumb result. On subsequent render calls, duplicate breadcrumbs would appear since the first item's name now contained the full breadcrumb result.
Closed
|
Thanks! |
|
I've published this fix as part of v1.8.0 now: https://github.com/zachinglis/crummy/releases/tag/v1.8.0 Thanks again |
GUI
added a commit
to NREL/api-umbrella-gatekeeper
that referenced
this pull request
Jul 27, 2015
This is fixed by using a custom renderer rather than the normal. Although the normal one should be fixed in a future version of crummy: zachinglis/crummy#49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event the first breadcrumb's name wasn't linked, that breadcrumb's name object was mutated into the full breadcrumb result. On subsequent render calls, duplicate breadcrumbs would appear since the
first item's name now contained the full breadcrumb result.
This should fix #45