Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use assert_dom_equal #44

Merged
merged 2 commits into from
May 8, 2013
Merged

Use assert_dom_equal #44

merged 2 commits into from
May 8, 2013

Conversation

sanemat
Copy link
Contributor

@sanemat sanemat commented May 8, 2013

  • Use assert_dom_equal instead of assert_equal
  • All green against rails4!

andrew added a commit that referenced this pull request May 8, 2013
@andrew
Merge pull request #44 from sanemat/feature/rails4
4e8ddf7 
Use assert_dom_equal
@andrew andrew merged commit 4e8ddf7 into zachinglis:master May 8, 2013
@andrew
Copy link
Contributor

andrew commented May 8, 2013

Thanks!

@frodsan
Copy link

frodsan commented Jul 3, 2013

Is crummy ready for Rails 4?

@andrew
Copy link
Contributor

andrew commented Jul 4, 2013

@frodsan yes I believe so

@andrew
Copy link
Contributor

andrew commented Oct 20, 2013

I've published this fix as part of v1.8.0 now: https://github.com/zachinglis/crummy/releases/tag/v1.8.0

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanemat @andrew @frodsan