Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install.sh removes group but not other permissions on zi.sh & zpmod #43

Closed
saizai opened this issue Jul 13, 2022 · 0 comments · Fixed by #44
Closed

Install.sh removes group but not other permissions on zi.sh & zpmod #43

saizai opened this issue Jul 13, 2022 · 0 comments · Fixed by #44

Comments

@saizai
Copy link
Contributor

saizai commented Jul 13, 2022 •
edited
Loading

Both of these should be go-rwX, not g-rwX:

zi-src/lib/sh/install.sh

Line 119 in 42b84c5

command mkdir -p "${ZI_HOME}" && command chmod g-rwX "${ZI_HOME}"

zi-src/lib/sh/install.sh

Line 174 in 42b84c5

chmod g-rwX "${ZI_HOME}/${MOD_HOME}"

While at it, I also consolidated a separate g-w and o-w:

zi-src/lib/sh/install.sh

Lines 63 to 64 in 42b84c5

command chmod g-w "${ZI_HOME}"
command chmod o-w "${ZI_HOME}"

saizai added a commit to saizai/zi-src that referenced this issue Jul 13, 2022
@saizai
Fix other permissions for zi.sh & zpmod z-shell#43
a1ed594 
Signed-off-by: Sai <[email protected]>
@saizai saizai mentioned this issue Jul 13, 2022
Merged
@saizai saizai changed the title Install.sh removes group but not other permissions on zpmod Install.sh removes group but not other permissions on zi.sh & zpmod Jul 13, 2022
@ss-o ss-o closed this as completed in #44 Jul 15, 2022
ss-o added a commit that referenced this issue Jul 15, 2022
@saizai @ss-o
Fix other permissions for zi.sh & zpmod (#44)
470a968 
Fix other permissions for zi.sh & zpmod #43

Signed-off-by: Sai <[email protected]>

Co-authored-by: Salvydas Lukosius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix other permissions for zi.sh & zpmod saizai/zi-src
1 participant
@saizai