-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP8.1 compatibility #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great 👏 I requested some changes to improve clarity.
Sure, no specific reasons why I used those, just a matter of habit adding those :) |
@eboye did you forget to push your changes, or will you push them later? 🙂 |
Sorry, here they are. The only thing I want to mention is that this one test fails after my tinkering:
|
@eboye thanks for the contributions! I made more changes, migrated to Pest from PHPUnit, migrated to GitHub actions from all other CI tools, and improved the code quality, then released https://github.com/yusufkandemir/microdata-parser/releases/tag/v1.0.0, enjoy! |
Great! |
Description
I've bumped the php version to 8.1 and added some strict types
Motivation and context
Future versions compatibility
How has this been tested?
unit tests included in the project
Screenshots (if appropriate)
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist: