new prefix for images produced in testing: baseline_ or thisPR_ #4956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can't just revert these commits by stacking more commits, these files need to be obliterated from the history. |
nastasha-w
force-pushed
the
markbeforeafter
branch
from
818609c to
0263eb2
Compare
|
@neutrinoceros I think I've fixed it for this specific branch; please let me know if it's not ok. |
|
Perfect ! |
neutrinoceros
added
enhancement
neutrinoceros
approved these changes
Jul 24, 2024
|
Before we merge this, it'd be great to check if it actually works as we think it does. Can you alter some image answer tests so we get to see a diff report ? We'll remove the temporary commit afterwards |
|
I was hoping the tests on PR #4939 would show that, since those image tests are failing anyway. It's why I merged these changes into that branch. |
|
I believe you mean #4939 |
Yup, thanks! I edited it. |
|
Hooray! Congratulations on your first merged pull request! We hope we keep seeing you around! 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I'm adding prefixes to the file names produced in
yt/yt/utilities/answer_testing/framework.py,dump_imagesfunction. This should make it straightforward to see which image is the baseline for the comparison and which has been produced by the pull request branch in thenosetesting output.This addresses issue #4954.