Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH actions workflow to check PR title and labels #4902

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yut23
Copy link
Member

@yut23 yut23 commented May 10, 2024

PR Summary

This replaces the mergeable bot, which has been flaky recently. I've tested it thoroughly at yut23#2, and it works as expected.

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@neutrinoceros
Copy link
Member

Thank you ! As I said on slack, I'm all for migrating away from this bot (as well as the WIP bot), but we need a code owner to actually remove them. This PR should not be merge before then, let's ping @matthewturk and @Xarthisius

@neutrinoceros neutrinoceros added the infrastructure Related to CI, versioning, websites, organizational issues, etc label May 11, 2024
chrishavlin
chrishavlin previously approved these changes Oct 1, 2024
Copy link
Contributor

@chrishavlin chrishavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure the mergeable bot was disabled -- so I think this one can be merged now. I'll also add/remove some labels to double check...

@chrishavlin chrishavlin added infrastructure Related to CI, versioning, websites, organizational issues, etc and removed infrastructure Related to CI, versioning, websites, organizational issues, etc labels Oct 1, 2024
@chrishavlin
Copy link
Contributor

chrishavlin commented Oct 1, 2024

oh. hmm. mergeable is still running. oops. not sure why I thought we had disabled it :)

@chrishavlin
Copy link
Contributor

ah, clarification from @Xarthisius : mergeable bot is still running but is no longer required for merge, which is where it was hanging.

@neutrinoceros
Copy link
Member

If the bot isn't blocking anymore, I'm not sure we need a replacement. I'll let you guys be the judges !

@neutrinoceros
Copy link
Member

this needs a rebase

@yut23 yut23 force-pushed the pr-label-workflow branch from 5a233bb to 917722a Compare November 12, 2024 20:30
@yut23 yut23 changed the title Add GH actions workflow to check PR labels Add GH actions workflow to check PR title and labels Nov 12, 2024
@yut23
Copy link
Member Author

yut23 commented Nov 12, 2024

I've updated this to also check for "WIP" in the PR title, which is the other thing the mergeable bot was checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to CI, versioning, websites, organizational issues, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants