fix non comparable error check

ysmood · Jan 8, 2024 · dd585ae · dd585ae
1 parent 0a754fa
commit dd585ae
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/assertions.go b/assertions.go
@@ -301,7 +301,7 @@ func (as Assertions) Is(x, y interface{}) {
 
 	if ae, ok := x.(error); ok {
 		if be, ok := y.(error); ok {
-			if ae == be {
+			if utils.SmartCompare(ae, be) == 0 {
 				return
 			}
 

diff --git a/assertions_test.go b/assertions_test.go
@@ -320,3 +320,15 @@ func TestCustomAssertionError(t *testing.T) {
 	g.Eq(1, 2)
 	m.check("custom eq")
 }
+
+type rawErr []byte
+
+func (r rawErr) Error() string {
+	return string(r)
+}
+
+func TestIsRawErr(t *testing.T) {
+	g := got.T(t)
+
+	g.Is(rawErr("ok"), rawErr("ok"))
+}