Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge hierarchy package into transform package #156

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Merge hierarchy package into transform package #156

merged 3 commits into from
Nov 12, 2024

Conversation

yohamta
Copy link
Owner

@yohamta yohamta commented Nov 9, 2024

Since we typically use the hierarchy and transform packages together, we plan to merge them into a single package. Additionally, utility functions in the hierarchy package should be made private since they are only used internally.

Change overview

  • Renamed functions in hierarchy package with the hierarchy prefix
  • Moved files from hierarchy package into transform package
  • Made internal hierarchy manipulation functions private

@yohamta
Copy link
Owner Author

yohamta commented Nov 9, 2024

I've made these changes quickly. Could you please review them when you have a chance? @m110

@m110
Copy link
Contributor

m110 commented Nov 11, 2024

Thank you @yohamta! Will try it out 🤝

@yohamta
Copy link
Owner Author

yohamta commented Nov 12, 2024

Cool, thank you for taking a look!

@yohamta yohamta merged commit 199b75a into main Nov 12, 2024
2 checks passed
@yohamta yohamta deleted the merge-package branch November 12, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants