Implement hierarchy.RemoveParent #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching and investigating this tricky bug with multiple parents! I totally agree that we should merge those packages together into the transform package. Probably splitting those packages makes no sense. |
yohamta
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I've been dealing with a very strange bug where one entity gets multiple parents. After wrestling with it for a while, I realized the issue was that Donburi recycled an entity ID for another object, which was already a child.
I realized that
RemoveRecursivedoesn't delete the objects from the child list, andtransform.RemoveParentdoesn't either.This should fix this, but I'm not sure if it's clear how to use hierarchy and transform now 🤔 Perhaps we could merge the code to
transformto make it clearer what's going on there. I'm not sure if it makes sense to use hierarchy without transforms.