fix: Any artisan command that drops tables erroring with unknown function: pg_total_relation_size() #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfox
requested changes
Dec 1, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
============================================
+ Coverage 87.30% 88.23% +0.93%
- Complexity 25 26 +1
============================================
Files 6 6
Lines 63 68 +5
============================================
+ Hits 55 60 +5
Misses 8 8 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Peter Fox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Laravel v10.34.0, any Artisan command that drops tables, errors with
unknown function: pg_total_relation_size().At least these three commands are affected:
db:wipemigrate:freshmigrate:refreshThis is due to PR #49020 that changed how the list of tables is loaded.
As far as I can tell, CRDB doesn't support getting table file size via SQL. There is an open issue here and corresponding PR to add
pg_total_relation_size().This PR overrides
compileTables()hardcoding the table size to-1.-1 as sizeinstead ofpg_total_relation_size(c.oid) as size.