Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unique indexes fixes #10

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Drop unique indexes fixes #10

merged 2 commits into from
Sep 26, 2022

Conversation

tryvin
Copy link
Contributor

@tryvin tryvin commented Sep 26, 2022

This fixes the drop of unique indexes as CockroachDB doesn't support it with the usual alter table

See cockroachdb/cockroach#42840

@tryvin tryvin changed the title Drop unique indexes Drop unique indexes fixes Sep 26, 2022
peterfox
peterfox approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@peterfox peterfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @tryvin

@peterfox peterfox merged commit 9a3a14f into ylsideas:main Sep 26, 2022
@tryvin tryvin deleted the drop_unique_indexes branch September 26, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterfox peterfox peterfox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tryvin @peterfox