-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract response generator from ErrorCatcher middleware #133
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
============================================
- Coverage 78.86% 77.31% -1.56%
- Complexity 170 180 +10
============================================
Files 13 14 +1
Lines 511 551 +40
============================================
+ Hits 403 426 +23
- Misses 108 125 +17 ☔ View full report in Codecov by Sentry. |
Good one overall but needs minor adjustments before being merged. |
What about "psr/event-dispatcher" dependency? It's absent in the master branch. Should it be added to the composer.json in this pr? |
Not need. |
I've added it to the "require-dev", because it required for tests. |
Good refactoring 👍 |
"psr/event-dispatcher" must be in the composer.json "require" section?