Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract response generator from ErrorCatcher middleware #133

Merged
merged 10 commits into from
Oct 10, 2024

Conversation

olegbaturin
Copy link
Contributor

@olegbaturin olegbaturin commented Sep 22, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #129

"psr/event-dispatcher" must be in the composer.json "require" section?

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.31%. Comparing base (033468a) to head (e8f5683).
Report is 42 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #133      +/-   ##
============================================
- Coverage     78.86%   77.31%   -1.56%     
- Complexity      170      180      +10     
============================================
  Files            13       14       +1     
  Lines           511      551      +40     
============================================
+ Hits            403      426      +23     
- Misses          108      125      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/ThrowableHandlerInterface.php Outdated Show resolved Hide resolved
src/ThrowableHandlerInterface.php Outdated Show resolved Hide resolved
src/Handler/ThrowableHandler.php Outdated Show resolved Hide resolved
src/ThrowableHandlerInterface.php Outdated Show resolved Hide resolved
src/Middleware/ErrorCatcher.php Show resolved Hide resolved
@samdark
Copy link
Member

samdark commented Sep 22, 2024

Good one overall but needs minor adjustments before being merged.

@olegbaturin
Copy link
Contributor Author

What about "psr/event-dispatcher" dependency? It's absent in the master branch. Should it be added to the composer.json in this pr?

@vjik
Copy link
Member

vjik commented Sep 26, 2024

What about "psr/event-dispatcher" dependency? It's absent in the master branch. Should it be added to the composer.json in this pr?

Not need. psr/event-dispatcher is optional dependency.

@olegbaturin
Copy link
Contributor Author

Not need. psr/event-dispatcher is optional dependency.

I've added it to the "require-dev", because it required for tests.

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@samdark samdark requested a review from vjik October 10, 2024 07:11
vjik
vjik approved these changes Oct 10, 2024
src/ThrowableResponseFactoryInterface.php Show resolved Hide resolved
@vjik vjik merged commit e98f687 into yiisoft:master Oct 10, 2024
15 of 19 checks passed
@vjik
Copy link
Member

vjik commented Oct 10, 2024

Good refactoring 👍

@olegbaturin olegbaturin deleted the extract-response-generator branch October 22, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants