Don't suggest to upgrade to lower version #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure, but I don't think so, since I've seen this problem happen on non-beta versions too. |
|
Yeah the 2 comments were unrelated. I think latest-version could return a version older than its supposed to, I don’t know what else could be happening. Is it still cached here? |
kmcnellis
added a commit
to firebase/firebase-tools
that referenced
this pull request
Apr 16, 2021
Update to a version that includes sindresorhus/update-notifier#192 to avoid the bug where it will suggest downgrading your version (sindresorhus/update-notifier#181).
kmcnellis
added a commit
to firebase/firebase-tools
that referenced
this pull request
Apr 16, 2021
Update to a version that includes sindresorhus/update-notifier#192 to avoid the bug where it will suggest downgrading your version (sindresorhus/update-notifier#181).
kmcnellis
added a commit
to firebase/firebase-tools
that referenced
this pull request
Apr 16, 2021
Update to a version that includes sindresorhus/update-notifier#192 to avoid the bug where it will suggest downgrading your version (sindresorhus/update-notifier#181).
kmcnellis
added a commit
to firebase/firebase-tools
that referenced
this pull request
Apr 19, 2021
Update to a version that includes sindresorhus/update-notifier#192 to avoid the bug where it will suggest downgrading your version (sindresorhus/update-notifier#181).
ghost
mentioned this pull request
ghost
pushed a commit
to snyk/cli
that referenced
this pull request
Apr 26, 2021
Older verions of update-notifier suggested updating to older versions. See sindresorhus/update-notifier#192
|
Hi, Not sure it's related but we got those messages reported here:
Any idea what could be happening? |
|
Looks like this bug is caused by the async nature of this package: fetch the update, and only notify about it on the 2nd run. As I have my own code to notify users, I think I should just backport your logic to my own notifier. Wouldn't it make sense to somehow "erase" this.update data if on 2nd run we detech packageVersion is > latest fetched version? This could fix the issue in a more generic way? |
slorber
added a commit
to facebook/docusaurus
that referenced
this pull request
May 13, 2021
slorber
added a commit
to facebook/docusaurus
that referenced
this pull request
May 13, 2021
5 tasks
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
Update to a version that includes sindresorhus/update-notifier#192 to avoid the bug where it will suggest downgrading your version (sindresorhus/update-notifier#181).
kodiakhq bot
pushed a commit
to vercel/vercel
that referenced
this pull request
May 31, 2022
Looks like this is a bug in update-notifier, but they [smoothed it over](sindresorhus/update-notifier#192) with a change that was deployed in [`5.0.0`](https://github.com/yeoman/update-notifier/releases/tag/v5.0.0). We’re currently on `4.1.0`. This can cause an update notification for a PREVIOUS version, like so: ``` $ vc --version > UPDATE AVAILABLE Run `npm i -g vercel@latest` to install Vercel CLI 24.2.5-canary.3 > Changelog: https://github.com/vercel/vercel/releases/tag/[email protected] Vercel CLI 24.2.5 24.2.5 ``` While we're here, also sets the [`updatecheckinterval`](https://github.com/yeoman/update-notifier#updatecheckinterval) to 1 week. --- Previous PR: #4896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181
I haven't investigated why this would happen in the first place, but I guess it could if you install a beta version.
Is that a bug in https://github.com/sindresorhus/latest-version?