Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent update notifications to older versions #1862

Merged
1 commit merged into from
Apr 27, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2021

Older versions of update-notifier suggested updating to older versions.

image (1)

Fix in this PR: sindresorhus/update-notifier#192
Released in 5.0.0: https://github.com/yeoman/update-notifier/releases

This PR upgrades update-notifier from 4.1.0 to 5.1.0. The major bump was dropping Node 8 support which is fine for us as we only support Node 10 and above.

@ghost ghost requested review from a team as code owners April 26, 2021 16:47
Older verions of update-notifier suggested updating to older versions. See sindresorhus/update-notifier#192
@ghost ghost force-pushed the fix/update-notifier-upgrade branch from 9e0d1de to 1b4dc80 Compare April 26, 2021 16:51
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2021

Expected release notes (by @jahed-snyk)

fixes:
prevent update notifications to older versions (1b4dc80)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@ghost ghost changed the title fix: upgrade update-notifier for detection fix fix: prevent update notifications to older versions Apr 26, 2021
@ghost ghost merged commit 7513f39 into master Apr 27, 2021
@ghost ghost deleted the fix/update-notifier-upgrade branch April 27, 2021 08:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant