Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IterableOf, MapEntry and MapEnvelope started using HashCode instead o… #1685

Merged
merged 2 commits into from
Nov 30, 2024
Merged

IterableOf, MapEntry and MapEnvelope started using HashCode instead o… #1685

merged 2 commits into from
Nov 30, 2024

Conversation

catdog905
Copy link

…f thir own hashing

#1440

@catdog905
Copy link
Author

@yegor256 Hello! Could you check this PR that may close #1440 issue?

@yegor256
Copy link
Owner

@catdog905 many thanks for your contribution! Please, run mvn clean install -Pqulice and then fix the code formatting issues

@catdog905
Copy link
Author

@yegor256 Hello! I've pulled master and seems all checks have passed. Is there anything left to do before merging?

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Nov 30, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit 0b162b5 into yegor256:master Nov 30, 2024
9 checks passed
@rultor
Copy link
Collaborator

rultor commented Nov 30, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 7min).

@yegor256
Copy link
Owner

@catdog905 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@catdog905 @yegor256 @rultor