Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapEnvelope should be a real envelope and the behaviour moved to MapOf #1384

Closed
victornoel opened this issue May 9, 2020 · 7 comments
Closed

Comments

@victornoel
Copy link
Collaborator

In the same way we improved the cactoos API by making ListEnvelope, SetEnvelope and so on real envelopes with actual behaviour such as equals, toString, hashcode, etc, moved to the ListOf, SetOf, etc classes. I believe we should continue and do the same for MapEnvelope and MapOf.

The final objective is to have MapOf as the main entry point to build instances of Map in cactoos (based on a HashMap), and have Sticky and Solid removed.

The existing Grouped and Merged classes seems to be coherent with this desired design, so that's good.

@0crat
Copy link
Collaborator

0crat commented May 9, 2020

@paulodamaso/z please, pay attention to this issue

@victornoel
Copy link
Collaborator Author

@0crat in

@victornoel
Copy link
Collaborator Author

@0crat assign @andreoss

@victornoel
Copy link
Collaborator Author

@andreoss I'm starting to assign manually because if not 0crat always assign latest issues and I would like to advance on those. I hope it's ok with you :) no rush anyway

@victornoel victornoel added this to the 1.0 milestone Sep 13, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 15, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 19, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 19, 2020
@victornoel
Copy link
Collaborator Author

@andreoss thx :)

@0crat 0crat added the qa label Sep 20, 2020
@0crat
Copy link
Collaborator

0crat commented Sep 20, 2020

@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the 0crat/scope label Sep 20, 2020
@sereshqua
Copy link

@0crat quality good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants