fix(pnp): ensure URL is imported on Node.js < 20
#6060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
force-pushed
the
merceyz/fix/pnp-custom-global-url-class
branch
from
bb88359 to
99b8c34
Compare
|
Is there a way to install this version? I need this job to fix |
|
A new release will be created soon but until then you can run yarn set version from sources |
|
This job was released in 4.1.0, but I need 3.x.x version of berry. Is there any plan to release this job in 3.x.x version? |
3 tasks
|
Can I install this commit in 3.x.x version? When I install |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Before nodejs/node#46904 using a custom global URL class wasn't supported by
fileURLToPath.Closes #6030
Fixes #5915
How did you fix it?
URLsince it's a global and to avoid mixing custom and builtin URL class instances.Checklist