[Bug?]: nodeLinker: node-modules is broken in Node.js 22.5.0
#6398
Labels
Comments
|
Bisects to nodejs/node#53627. |
3 tasks
|
Can you open a new issue to Node.js repository, with a reproduction that is easily reproducible without Yarn? |
arcanis
pushed a commit
that referenced
this issue
Jul 18, 2024
**What's the problem this PR addresses?** If the event loop unexpectedly becomes empty `yarn` will terminate with exit code 0 even though the command didn't complete successfully. Ref nodejs/node#53902 Ref #6398 where that happens and the install is incomplete when `yarn` terminates with exit code 0. It's caught in the following `yarn build` step which can't find the install state. **How did you fix it?** Set `process.exitCode` to an error code before executing the CLI so an unexpected empty event loop counts as an error. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this issue
Jul 18, 2024
This reverts commit ed6f45b. PR-URL: #53904 Refs: yarnpkg/berry#6398 Refs: npm/cli#7657 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
richardlau
pushed a commit
to nodejs/node
that referenced
this issue
Jul 19, 2024
This reverts commit ed6f45b. PR-URL: #53904 Refs: yarnpkg/berry#6398 Refs: npm/cli#7657 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
richardlau
added a commit
to nodejs/node
that referenced
this issue
Jul 19, 2024
Notable changes: This release fixes a regression introduced in Node.js 22.5.0. The problem is known to display the following symptoms: - Crash with ``` FATAL ERROR: v8::Object::GetCreationContextChecked No creation context available ``` - npm errors with `npm error Exit handler never called!` - yarn hangs or outputs ``` Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation) ``` PR-URL: #53935 Refs: #53902 Refs: npm/cli#7657 Refs: yarnpkg/berry#6398
Bullrich
added a commit
to paritytech/metrics
that referenced
this issue
Jul 19, 2024
It seems that it is a problem related to node yarnpkg/berry#6398 so downgrading the library should fix it
Bullrich
added a commit
to paritytech/metrics
that referenced
this issue
Jul 19, 2024
While yarnpkg/berry#6398 is a problem, it may be better to use npm
olibos
added a commit
to olibos/fleet-management
that referenced
this issue
Jul 19, 2024
richardlau
added a commit
to nodejs/node
that referenced
this issue
Jul 19, 2024
Notable changes: This release fixes a regression introduced in Node.js 22.5.0. The problem is known to display the following symptoms: - Crash with ``` FATAL ERROR: v8::Object::GetCreationContextChecked No creation context available ``` - npm errors with `npm error Exit handler never called!` - yarn hangs or outputs ``` Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation) ``` PR-URL: #53935 Refs: #53902 Refs: npm/cli#7657 Refs: yarnpkg/berry#6398
|
Closing as Node.js v22.5.1 has been released with a fix for this issue. |
mcmire
added a commit
to MetaMask/eth-json-rpc-middleware
that referenced
this issue
Jul 19, 2024
There seems to be a regression in Node 22.5.0 which [prevents `yarn install` from running][1] and in turns prevents CI from completing successfully. This regression was [fixed in 22.5.1][2], so this commit ensures that CI is using this version. [1]: yarnpkg/berry#6398 [2]: nodejs/node#53935
mcmire
added a commit
to MetaMask/eth-json-rpc-middleware
that referenced
this issue
Jul 19, 2024
There seems to be a regression in Node 22.5.0 which [prevents `yarn install` from running][1] and in turns prevents CI from completing successfully. This regression was [fixed in 22.5.1][2]. We are using `22.x` in CI, so in theory it should be using this version, but that does not seem be the case right now. So this commit ensures that CI is using this version by naming it explicitly. [1]: yarnpkg/berry#6398 [2]: nodejs/node#53935
mcmire
added a commit
to MetaMask/eth-json-rpc-middleware
that referenced
this issue
Jul 19, 2024
There seems to be a regression in Node 22.5.0 which [prevents `yarn install` from running][1] and in turns prevents CI from completing successfully. This regression was [fixed in 22.5.1][2]. We are using `22.x` in CI, so in theory it should be using this version, but that does not seem be the case right now. So this commit ensures that CI is using this version by naming it explicitly. [1]: yarnpkg/berry#6398 [2]: nodejs/node#53935
This was referenced Jul 22, 2024
github-merge-queue bot
pushed a commit
to rustymotors/server
that referenced
this issue
Jul 24, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://togithub.com/nodejs/node)) | patch | `22.5.0` -> `22.5.1` | --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v22.5.1`](https://togithub.com/nodejs/node/releases/tag/v22.5.1): 2024-07-19, Version 22.5.1 (Current), @​richardlau [Compare Source](https://togithub.com/nodejs/node/compare/v22.5.0...v22.5.1) ##### Notable Changes This release fixes a regression introduced in Node.js 22.5.0. The problem is known to display the following symptoms: - Crash with `FATAL ERROR: v8::Object::GetCreationContextChecked No creation context available` [#​53902](https://togithub.com/nodejs/node/issues/53902) - npm errors with `npm error Exit handler never called!` [npm/cli#7657](https://togithub.com/npm/cli/issues/7657) - yarn hangs or outputs `Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation)` [yarnpkg/berry#6398](https://togithub.com/yarnpkg/berry/issues/6398) ##### Commits - \[[`e2deeedc6e`](https://togithub.com/nodejs/node/commit/e2deeedc6e)] - ***Revert*** "**fs**: add v8 fast api to closeSync" (Aviv Keller) [#​53904](https://togithub.com/nodejs/node/pull/53904) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/rustymotors/server-old). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
](https://renovatebot.com){kind=link}
|
Just for those searching for the problem on google (etc.) Updating/Downgrading fixes this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Self-service
Describe the bug
On my local machine: freeze during the link step (clean install)
On CI:
Couldn't find the node_modules state file - running an install might help (findPackageLocation)To reproduce
Repo: https://github.com/latin-1/berry-node-22.5.0-broken
Node.js 22.4.1:
https://github.com/latin-1/berry-node-22.5.0-broken/actions/runs/9978668516/job/27576055285
Node.js 22.5.0:
https://github.com/latin-1/berry-node-22.5.0-broken/actions/runs/9978678303/job/27576083419
Environment
System: OS: Linux 6.9 Arch Linux CPU: (16) x64 AMD Ryzen 7 6800U with Radeon Graphics Binaries: Node: 22.5.0 - /tmp/xfs-8a836774/node Yarn: 4.3.1 - /tmp/xfs-8a836774/yarn npm: 10.8.2 - ~/.proto/shims/npm pnpm: 9.5.0 - ~/.proto/shims/pnpm bun: 1.1.20 - ~/.proto/shims/bun npmPackages: jest: 29.7.0 => 29.7.0Additional context
No response
The text was updated successfully, but these errors were encountered: