Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NPM packages - Phase 1 (Update mocha & migrated to nyc) #1224

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

melroy89
Copy link
Contributor

@melroy89 melroy89 commented Sep 10, 2024

  • All tests pass
  • I have run npm run doc

Description

All the packages are outdated of this NodeJS project. So this is my attempt to get all the NPM depedences upgraded, starting with phase 1.

In this phase 1 PR, I focused first of upgrading Mocha. And migrating away from Istanbul to the new nyc command. Which should be compatible.

If you didn't know, instanbul is NOT maintained anymore: https://www.npmjs.com/package/istanbul, but.. nyc is: https://github.com/istanbuljs/nyc

@melroy89
Copy link
Contributor Author

Before update mocha, I got already an error. So if somebody knows how to run your node-telegram-bot-api tests under Linux, let me know. I still get:

(node:35009) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
node:events:498
      throw er; // Unhandled 'error' event
      ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string or an instance of Buffer or URL. Received undefined
    at Object.open (node:fs:533:10)
    at ReadStream._construct (node:internal/fs/streams:72:17)
    at constructNT (node:internal/streams/destroy:300:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:89:21)
Emitted 'error' event on ReadStream instance at:
    at emitErrorNT (node:internal/streams/destroy:170:8)
    at emitErrorCloseNT (node:internal/streams/destroy:129:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Node.js v22.8.0

But expect your pipeline to still succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant