Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

漢数字やコンマなどの正規化前の時刻表現の文字列とスパンをTIMEXタグに含める #70

Merged
merged 1 commit into from
Jan 29, 2022
Merged

漢数字やコンマなどの正規化前の時刻表現の文字列とスパンをTIMEXタグに含める #70

merged 1 commit into from
Jan 29, 2022

Conversation

yagays
Copy link
Owner

@yagays yagays commented Jan 29, 2022 •
edited
Loading

#67 の対応

@yagays yagays added the bug Something isn't working label Jan 29, 2022
@yagays yagays changed the title support text and span before number normalizing 漢数字やコンマなどの正規化前の時刻表現の文字列とスパンをTIMEXタグに含める Jan 29, 2022
yagays
yagays commented Jan 29, 2022
View reviewed changes
ja_timex/tag.py
span: Tuple[int, int]

# 正規化前の抽出テキストと開始終了位置
raw_text: Optional[str] = None
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

現在のロジックではraw_textおよびraw_spanはNoneになることはないが、Optionalを外すことによるテストへの影響が大きいため、このPRでは対応しない。

@yagays yagays marked this pull request as ready for review January 29, 2022 04:01
@yagays yagays merged commit fa71817 into master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yagays