Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XEP-0380: EME: Add omemo:1 as encryption method #907

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

XEP-0380: EME: Add omemo:1 as encryption method #907

wants to merge 1 commit into from

Conversation

lnjX
Copy link
Contributor

@lnjX lnjX commented Mar 11, 2020

omemo:1 is incompatible with OMEMO <= 0.3

@lnjX
XEP-0380: EME: Add omemo:1 as encryption method
49c0438 
omemo:1 is incompatible with OMEMO <= 0.3
@Ppjet6 Ppjet6 requested a review from linkmauve March 11, 2020 17:45
@Ppjet6 Ppjet6 added Needs Author The XEP is experimental and the PR was not made by the author. The author needs to acknowledge it. Needs Version Block The change requires a version block, and this is to be done by Editors at merge time. labels Mar 11, 2020
@lnjX
Copy link
Contributor Author

lnjX commented Mar 11, 2020

@Ppjet6 Needs Version Block? - I already added a version block.

@Ppjet6 Ppjet6 removed the Needs Version Block The change requires a version block, and this is to be done by Editors at merge time. label Mar 11, 2020
@Ppjet6
Copy link
Contributor

Ppjet6 commented Mar 11, 2020

oops! Thanks!

@linkmauve
Copy link
Member

Hi, and thanks for this PR!

But I don’t feel like this belongs to the XEP, instead the next version will request a registry from the registrar so that we don’t have to update the XEP every time we had a new encryption mechanism.

@lnjX
Copy link
Contributor Author

lnjX commented Mar 14, 2020

@linkmauve Yes that's the better solution!

@lnjX lnjX closed this Mar 14, 2020
@Ppjet6 Ppjet6 reopened this Mar 15, 2020
@Ppjet6
Copy link
Contributor

Ppjet6 commented Mar 15, 2020

I'm reopening this just to keep track. There's some other work also blocking on the registry atm..

@Ppjet6 Ppjet6 added Needs Registry The Registry is currently not available and some work is blocking on it and removed Needs Author The XEP is experimental and the PR was not made by the author. The author needs to acknowledge it. labels Mar 15, 2020
@lnjX
Copy link
Contributor Author

lnjX commented Jul 15, 2022

#1127 was merged without using the registrar. However I think I can close this now?

@Neustradamus
Copy link

@linkmauve, @Ppjet6: @lnjX has done a question, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linkmauve linkmauve Awaiting requested review from linkmauve

Assignees
No one assigned
Labels
Needs Registry The Registry is currently not available and some work is blocking on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lnjX @Ppjet6 @linkmauve @Neustradamus