Add Component Build Command #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criles25
reviewed
Jan 23, 2020
| const chalk = require('react-dev-utils/chalk'); | ||
| const fs = require('fs-extra'); | ||
| const webpack = require('webpack'); | ||
| const configFactory = require('../config/webpack.config'); |
There was a problem hiding this comment.
this part might be slightly tricky, but basically we will need to change the config object that configFactory produces on like 63.
it could be as simple as reassigning some of the properties and values inside the object.
| @@ -24,7 +24,7 @@ const scriptIndex = args.findIndex( | |||
| const script = scriptIndex === -1 ? args[0] : args[scriptIndex]; | |||
| const nodeArgs = scriptIndex > 0 ? args.slice(0, scriptIndex) : []; | |||
|
|
|||
| if (['build', 'eject', 'start', 'test'].includes(script)) { | |||
| if (['build', 'eject', 'start', 'test', 'build-component'].includes(script)) { | |||
There was a problem hiding this comment.
it looks like you're on the right path here. i don't know all the places you have to declare this new build-component script exists, but we could probably just grep for build or whatever to find out.
criles25
reviewed
Jan 28, 2020
| default: false, | ||
| }, | ||
| }; | ||
| config.output.filename = 'main.js'; |
There was a problem hiding this comment.
I'm just making a note here
we will eventually want to declare external dependencies here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.