Add missing event mask fields to WindowAttributes #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this pull request
May 14, 2021
Decoration windows are created using XMonad.Util.XUtils.createNewWindow which happens to set _NET_WM_WINDOW_TYPE to _NET_WM_WINDOW_TYPE_DESKTOP, and ManageDocks considers such windows candidates for struts and therefore requests property events, thus overriding the original event mask requested by decorations. The fix is to first obtain the current event mask, set the required bits in it only then reset the mask. Fixes: xmonad#517 Fixes: ec14617 ("X.H.ManageDocks: React to strut updates of override_redirect docks") Related: xmonad/X11#77
liskin
force-pushed
the
pr/window-attributes-event-mask
branch
from
33e5606 to
3b12e30
Compare
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this pull request
May 14, 2021
Decoration windows are created using XMonad.Util.XUtils.createNewWindow which happens to set _NET_WM_WINDOW_TYPE to _NET_WM_WINDOW_TYPE_DESKTOP, and ManageDocks considers such windows candidates for struts and therefore requests property events, thus overriding the original event mask requested by decorations. The fix is to first obtain the current event mask, set the required bits in it only then reset the mask. Fixes: xmonad#517 Fixes: ec14617 ("X.H.ManageDocks: React to strut updates of override_redirect docks") Related: xmonad/X11#77
This is a prerequisite to fix a recent xmonad-contrib regression caused by X.H.ManageDocks overriding the event mask (selectInput) of a decoration window. The proposed fix is to first obtain the current event mask, set the required bits in it only then reset the mask. Related: xmonad/xmonad-contrib#517 Related: xmonad/xmonad-contrib#545
liskin
force-pushed
the
pr/window-attributes-event-mask
branch
from
3b12e30 to
5319673
Compare
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this pull request
Jun 1, 2021
Decoration windows are created using XMonad.Util.XUtils.createNewWindow which happens to set _NET_WM_WINDOW_TYPE to _NET_WM_WINDOW_TYPE_DESKTOP, and ManageDocks considers such windows candidates for struts and therefore requests property events, thus overriding the original event mask requested by decorations. The fix is to first obtain the current event mask, set the required bits in it only then reset the mask. Fixes: xmonad#517 Fixes: ec14617 ("X.H.ManageDocks: React to strut updates of override_redirect docks") Related: xmonad/X11#77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite to fix a recent xmonad-contrib regression
caused by X.H.ManageDocks overriding the event mask (selectInput) of
a decoration window. The proposed fix is to first obtain the current
event mask, set the required bits in it only then reset the mask.
Related: xmonad/xmonad-contrib#517
Related: xmonad/xmonad-contrib#545