Add XRRGetMonitors binding #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jokogr Please rebase this to master and get travis building and I will do a code review. Thanks. |
jokogr
force-pushed
the
add-xrrGetMonitors
branch
from
61493f3 to
d0f9d94
Compare
|
@pjones I have pushed a new version which removes the XFree() call as done in previous commits, but I still have to fix Travis. The code is compiling and working on my own machine. Unfortunately, XRandR v1.5 has only made it officially since Ubuntu 16.04 (Xenial Xerus). Travis currently supports Ubuntu 12.04 and 14.04 (the latter in beta), both of which have a lower version of 1.5. Let me know what you want me to do: I could keep this open until Travis gets Ubuntu 16.04 or higher, or close it and open a new PR in the future. |
|
Let's leave this PR open for now. Let's see where XRandR and Travis are when we get ready for the next X11 release. |
jokogr
force-pushed
the
add-xrrGetMonitors
branch
from
d0f9d94 to
951ceab
Compare
jokogr
force-pushed
the
add-xrrGetMonitors
branch
3 times, most recently
from
80d03cb to
3f47c1b
Compare
jokogr
force-pushed
the
add-xrrGetMonitors
branch
from
3f47c1b to
3c8f540
Compare
peti
suggested changes
Sep 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RandR 1.5 adds a nice function to get information on active monitors.
I have managed to write a small test which shows that the pulled code works correctly. However, I'm not so familiar with FFI, I have just repeated the logic I saw in other functions, so please review it with caution.